buggnokii - Bugs: bug #25137, String corruption?

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25137: String corruption?

Submitted by:  Isakov Alexandr <isakovan>
Submitted on:  Sat 20 Dec 2008 08:23:35 PM UTC  
 
Category: gnokiiSeverity: 3 - Normal
Item Group: minor malfunctionStatus: Fixed
Privacy: PublicAssigned to: BORBELY Zoltan <bozo>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 24 Dec 2008 08:37:47 AM UTC, comment #7:

Patch committed. Thanks for testing.

Pawel Kot <pkot>
Project Administrator
Wed 24 Dec 2008 08:28:51 AM UTC, comment #6:

gnokii.log - log with unpatched version
gnokii2.log - log with patched version - WORKS FINE!
Patch removed all junk. Thanks!

(file #17132, file #17133)

Isakov Alexandr <isakovan>
Tue 23 Dec 2008 10:25:19 PM UTC, comment #5:

Here is updated patch version which makes it work aligned to my guess

(file #17131)

Pawel Kot <pkot>
Project Administrator
Tue 23 Dec 2008 10:19:05 PM UTC, comment #4:

Here is at least partial patch against this. Unfortunately I don't understand from the code what value should be put before the string. Unfortunately I don't have the phone to test.

The thing that is worrying me is in gnapplet in (I belive this one is to decode string):
PktBuf &operator>>(PktBuf &buf, TDes &x)
{
...
b = buf.ExpandL(2 * l);
x.SetLength(l);
...
}
So in fact number of characters in the string should be passed there. And it is not entirely true as pkt.c contains:
void pkt_put_string(pkt_buffer buf, const char x)
{
...
uint16_t n = strlen(x);
pkt_put_uint16(buf, n);
...
}
and for utf8 strings strlen() doesn't denote number of characters.

Bozo, what's the intention?

(file #17130)

Pawel Kot <pkot>
Project Administrator
Tue 23 Dec 2008 09:16:31 PM UTC, comment #3:

Can you provide debug log for that operation?

Pawel Kot <pkot>
Project Administrator
Sun 21 Dec 2008 06:28:25 AM UTC, comment #2:

Linked to ical.

Additional info(if needed):
Gentoo linux
app-mobilephone/gnokii-0.6.27 (X bluetooth ical irda mysql nls sms usb)
Gnapplet from http://www.gnokii.org/download/gnapplet/gnapplet.sis
Locale: ru_RU.UTF-8
Phone: Nokia 6260

Isakov Alexandr <isakovan>
Sat 20 Dec 2008 10:09:01 PM UTC, comment #1:

Do you use gnokii linked to libical? Or vcal support from gnokii?

Pawel Kot <pkot>
Project Administrator
Sat 20 Dec 2008 08:23:35 PM UTC, original submission:

gnokii --writecalendarnote test.ics 1 end

This should create calendar note with name "test" in Russian. But in result name of note contain not only word "ั‚ะตัั‚" but also four empty boxes. It seems than some junk added at the end.

Isakov Alexandr <isakovan>

 

Attached Files
file #17132:  gnokii.log added by isakovan (16KiB - text/x-log)
file #17133:  gnokii2.log added by isakovan (16KiB - text/x-log)
file #17131:  pktputsting.patch added by pkot (961B - text/x-patch)
file #17103:  .gnokiirc added by isakovan (94B - application/octet-stream)
file #17104:  test.ics added by isakovan (341B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pkot (Posted a comment)
  • -unavailable- added by isakovan (Submitted the item)
  • -unavailable- added by isakovan
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 Dec 2008 08:37:47 AM UTCpkotStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Wed 24 Dec 2008 08:28:51 AM UTCisakovanAttached File-=>Added gnokii.log, #17132
      Attached File-=>Added gnokii2.log, #17133
    Tue 23 Dec 2008 10:25:42 PM UTCpkotAttached File#17130=>Removed
    Tue 23 Dec 2008 10:25:19 PM UTCpkotAttached File-=>Added pktputsting.patch, #17131
    Tue 23 Dec 2008 10:19:05 PM UTCpkotAttached File-=>Added pktputstring.patch, #17130
      Assigned toNone=>bozo
    Tue 23 Dec 2008 09:16:29 PM UTCpkotStatusNone=>Need Info
    Sat 20 Dec 2008 08:23:35 PM UTCisakovanAttached File-=>Added .gnokiirc, #17103
      Attached File-=>Added test.ics, #17104
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1