bugThe FreeType Project - Bugs: bug #25347, POSIX resource fork accessor in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25347: POSIX resource fork accessor in 2.3.8 is broken since CVS 2008-10-04

Submitter:  suzuki toshiya <mpsuzuki>
Submitted:  Fri 16 Jan 2009 05:36:49 PM UTC
   
 
Severity:  3 - Normal Item Group:  Incorrect behaviour
Status:  Fixed Privacy:  Public
Assigned to:  mpsuzuki Open/Closed:  Closed
Planned Release:  2.3.9

Thu 22 Jan 2009 03:54:19 AM UTC, comment #1: 

Patch is posted to ft-devel list and there was no objection,
it is committed to CVS.

suzuki toshiya <mpsuzuki>
Group administrator
Fri 16 Jan 2009 05:36:49 PM UTC, original submission:  

When I added a preliminary support for sfnt-wrapped PostScript
Type1 & CID-keyed font, I had broken Mac_Read_sfnt_Resource()
in src/base/ftobjs.c.

Before all, Mac_Read_sfnt_Resource() tries to open PS Type1
or CID-keyed font in temporal sfnt stream. If failed, whole of
sfnt stream is copied to memory buffer, and the buffer is passed
to open_face_from_buffer() (and TrueType face would be opened).

In some case (e.g. PS Type1 nor CID-keyed font is not found),
open_face_PS_from_sfnt_stream() returns without restoring
the position of the sfnt stream. Thus, the copying of sfnt
stream to memory buffer by Mac_Read_sfnt_Resource() can
make wrong image due to unexpected position of sfnt stream.

The fix would be one of followings.

Fix 1) Improve open_face_PS_from_sfnt_stream() to restore
the position of sfnt stream always.

Fix 2) Improve Mac_Read_sfnt_Resource() to seek the sfnt
stream to correct position by itself, even if it is shifted
by open_face_PS_from_sfnt_stream().

Attached short patch includes both.

suzuki toshiya <mpsuzuki>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #17272:  fix-posix-rfork.patch added by mpsuzuki (989B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mpsuzuki
  • -email is unavailable- added by mpsuzuki (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-01-22 mpsuzuki StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.3.9
    2009-01-16 mpsuzuki Attached File- Added fix-posix-rfork.patch, #17272
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code