bugThe FreeType Project - Bugs: bug #25347, POSIX resource fork accessor in...

 
 

bug #25347: POSIX resource fork accessor in 2.3.8 is broken since CVS 2008-10-04

Submitted by:  suzuki toshiya <mpsuzuki>
Submitted on:  Fri 16 Jan 2009 05:36:49 PM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: suzuki toshiya <mpsuzuki>Open/Closed: Closed
Planned Release: 2.3.9

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 22 Jan 2009 03:54:19 AM UTC, comment #1:

Patch is posted to ft-devel list and there was no objection,
it is committed to CVS.

suzuki toshiya <mpsuzuki>
Project AdministratorIn charge of this item.
Fri 16 Jan 2009 05:36:49 PM UTC, original submission:

When I added a preliminary support for sfnt-wrapped PostScript
Type1 & CID-keyed font, I had broken Mac_Read_sfnt_Resource()
in src/base/ftobjs.c.

Before all, Mac_Read_sfnt_Resource() tries to open PS Type1
or CID-keyed font in temporal sfnt stream. If failed, whole of
sfnt stream is copied to memory buffer, and the buffer is passed
to open_face_from_buffer() (and TrueType face would be opened).

In some case (e.g. PS Type1 nor CID-keyed font is not found),
open_face_PS_from_sfnt_stream() returns without restoring
the position of the sfnt stream. Thus, the copying of sfnt
stream to memory buffer by Mac_Read_sfnt_Resource() can
make wrong image due to unexpected position of sfnt stream.

The fix would be one of followings.

Fix 1) Improve open_face_PS_from_sfnt_stream() to restore
the position of sfnt stream always.

Fix 2) Improve Mac_Read_sfnt_Resource() to seek the sfnt
stream to correct position by itself, even if it is shifted
by open_face_PS_from_sfnt_stream().

Attached short patch includes both.

suzuki toshiya <mpsuzuki>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17272:  fix-posix-rfork.patch added by mpsuzuki (989B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mpsuzuki
  • -unavailable- added by mpsuzuki (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 Jan 2009 03:54:19 AM UTCmpsuzukiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.9
    Fri 16 Jan 2009 05:36:49 PM UTCmpsuzukiAttached File-=>Added fix-posix-rfork.patch, #17272
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1