bugThe FreeType Project - Bugs: bug #25355, FT_MulFix_i386 asm statement...

 
 

bug #25355: FT_MulFix_i386 asm statement incompatible with GCC 2.95.3

Submitted by:  Michael Lotz <mmlr>
Submitted on:  Mon 19 Jan 2009 12:41:19 AM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.9

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Jan 2009 08:57:06 AM UTC, comment #1:

Applied, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Mon 19 Jan 2009 12:41:19 AM UTC, original submission:

Hi there

I'm a developer on the Haiku project. We use freetype for font extraction/rendering and we're also still using GCC 2.95.3. Since updating our freetype to 2.3.8, compilation fails like this:

ftconfig.h:362: impossible register constraint in `asm'
ftconfig.h:362: `asm' needs too many reloads

I've tracked this down to the usage of the "+d" input/output constraint in FT_MulFix_i386 that apparently doesn't work with our GCC version. I've replaced it with a "=d" output and "d" input constraint instead, which should be functionally equivalent. This works fine on GCC 2.95.3.

Another thing that was brought to my attention is that imul will clobber the conditional code register and therefore "cc" should be added to the clobber list.

The attached patch should fix both issues.

Michael Lotz <mmlr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17288:  freetype.diff added by mmlr (544B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by mmlr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 Jan 2009 08:57:06 AM UTCwlStatusNone=>Fixed
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.9
    Mon 19 Jan 2009 12:41:19 AM UTCmmlrAttached File-=>Added freetype.diff, #17288

    Back to the top


    Powered by Savane 3.1-cleanup1