bugGnome Chemistry Utils - Bugs: bug #25628, 0.10.3 does not build with gcc-4.4

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25628: 0.10.3 does not build with gcc-4.4

Submitted by:  Julian Sikorski <belegdol>
Submitted on:  Wed 18 Feb 2009 10:57:14 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jean Bréfort <jean_brefort>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 18 Mar 2009 05:27:00 PM UTC, comment #19:

Closed after 0.10.4 release.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 25 Feb 2009 09:18:59 PM UTC, comment #18:

Patches commited to both branches.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 25 Feb 2009 05:27:08 AM UTC, comment #17:

Looks good. I'll commit it as soon as possible.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Tue 24 Feb 2009 09:27:17 PM UTC, comment #16:

How about this one?

(file #17525)

Julian Sikorski <belegdol>
Project Member
Tue 24 Feb 2009 08:14:43 PM UTC, comment #15:

this patch would break the build against the old xulrunner versions. It needs some editing.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Tue 24 Feb 2009 03:30:12 PM UTC, comment #14:

Problem solved, Martin Stransky was kind enough to provide a patch. He says that the HAVE_NPFUNCTIONS_H definition needs to go to config.h. This patch goes on top of 25628-2.patch.

(file #17521)

Julian Sikorski <belegdol>
Project Member
Fri 20 Feb 2009 02:07:12 PM UTC, comment #13:

I filed a ticket with a request for help from gecko maintainers:
https://bugzilla.redhat.com/show_bug.cgi?id=486589

Julian Sikorski <belegdol>
Project Member
Thu 19 Feb 2009 07:14:10 AM UTC, comment #12:

Your patch looks better than mine. Looks like some headers are missing such as errno.h and stdio.h. And there are apparently important changes in the xulrunner headers. I'll try to have a look at that as soon as possible.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Thu 19 Feb 2009 01:35:53 AM UTC, comment #11:

I tried applying your patch against 0.10.3 and then running autoreconf, but it seems that something went wrong at that point:
http://belegdol.fedorapeople.org/build.log.libtool
I also tried to prepare a patch on a basis of
http://cvs.savannah.gnu.org/viewvc/classpath/native/plugin/gcjwebplugin.cc?root=classpath&r1=1.13&r2=1.14&diff_format=u
which I was pointed to as an example of required changes (attached). Unsurprisingly, that didn't work either:
http://belegdol.fedorapeople.org/build.log

(file #17481)

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 05:16:58 PM UTC, comment #10:

Hopefully this updated patch (against svn) will work.

(file #17477)

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 18 Feb 2009 05:04:54 PM UTC, comment #9:

npupp.h might have been renamed npfuctions.h, see https://bugzilla.mozilla.org/show_bug.cgi?id=455458

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 18 Feb 2009 04:04:24 PM UTC, comment #8:

http://belegdol.fedorapeople.org/build.log

Basically, npupp.h does not exist any more (or got moved, I'm not sure). I'll try to get a patch from gecko folks, or otherwise get as much information as possible.

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 04:01:25 PM UTC, comment #7:

Mau be I can help if I know what the issue is. Otherwise, a patch is welcome.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 18 Feb 2009 03:45:39 PM UTC, comment #6:

The updated patch fixed the problem, now we're back at xulrunner thing. I'll try to get help from the gecko folks.

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 03:06:18 PM UTC, comment #5:

The patch did the trick, it now blows at
spectrumdoc.cc: In member function 'void gcu::SpectrumDocument::ReadDataLine(const char*, std::list<double, std::allocator<double> >&)':
spectrumdoc.cc:1414: error: invalid conversion from 'const char' to 'char'
It can work for you because this issue is probably caused by new glibc as well (that's what I make out of Ulrich's post, at least).

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 02:40:23 PM UTC, comment #4:

I see, please try attached patch (anyaay, note that it works for me with gcc-snapshot).

(file #17475)

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 18 Feb 2009 02:21:41 PM UTC, comment #3:

Got a response, please have a look at http://thread.gmane.org/gmane.linux.redhat.fedora.devel/105736

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 01:42:41 PM UTC, comment #2:

I asked for directions on fedora-devel-list, let's see what glibc/gcc maintainers have to say.

Julian Sikorski <belegdol>
Project Member
Wed 18 Feb 2009 11:56:46 AM UTC, comment #1:

Looks like the issue comes with strchr.

man strchr says:
char strchr(const char s, int c);

I don't see what is wrong since the argument is a const char* string.

I can't reproduce the issue. May be the signature of strchr changed in glibc? Anyway, the above signature is not consistent since it returns a char* which is a substring of a const char*.
If this is the case, there is a need for a test in configure to find which signature version is available.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 18 Feb 2009 10:57:14 AM UTC, original submission:

Hi,

I'm trying to get gchemutils in shape for a mass rebuild, which is going to take place before Fedora 11 release. Unfortunately, I'm having a FTBFS issue here. xulrunner problem aside (I'm going to ask gecko maintainers for help), I have found another one:
element.cc: In function 'void ReadValue(const char*, GcuValue&)':
element.cc:49: error: invalid conversion from 'const char' to 'char'
element.cc: In function 'void ReadDimensionalValue(const char*, GcuDimensionalValue&)':
element.cc:58: error: invalid conversion from 'const char' to 'char'
make[3]:

      • [element.lo] Error 1

Please advice.

Julian Sikorski <belegdol>
Project Member

 

Attached Files
file #17525:  gnome-chemistry-npapi-1.9.1.patch added by belegdol (2KiB - text/x-patch - Patch by Martin Stransky, with some conditionals added by me)
file #17521:  gnome-chemistry-npapi-1.9.1.patch added by belegdol (2KiB - text/x-patch - Patch by Martin Stransky)
file #17477:  25628-2.patch added by jean_brefort (2KiB - text/x-patch - checks for npfunctions.h)
file #17476:  25628-1.patch added by jean_brefort (1KiB - text/x-patch - Updated patch, should fix spectrumdoc.cc as well)
file #17475:  25628.patch added by jean_brefort (921B - text/x-patch - proposed patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jean_brefort (Posted a comment)
  • -unavailable- added by belegdol (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Mar 2009 05:27:00 PM UTCjean_brefortOpen/ClosedOpen=>Closed
    Wed 25 Feb 2009 09:18:59 PM UTCjean_brefortStatusNeed Info=>Fixed
    Tue 24 Feb 2009 09:27:17 PM UTCbelegdolAttached File-=>Added gnome-chemistry-npapi-1.9.1.patch, #17525
    Tue 24 Feb 2009 03:30:12 PM UTCbelegdolAttached File-=>Added gnome-chemistry-npapi-1.9.1.patch, #17521
    Tue 24 Feb 2009 03:29:50 PM UTCbelegdolAttached File#17481=>Removed
    Thu 19 Feb 2009 01:35:53 AM UTCbelegdolAttached File-=>Added gnome-chemistry-utils-0.10.3-xulrunner191.patch, #17481
    Wed 18 Feb 2009 05:16:58 PM UTCjean_brefortAttached File-=>Added 25628-2.patch, #17477
    Wed 18 Feb 2009 03:24:50 PM UTCjean_brefortAttached File-=>Added 25628-1.patch, #17476
    Wed 18 Feb 2009 02:40:23 PM UTCjean_brefortAttached File-=>Added 25628.patch, #17475
    Wed 18 Feb 2009 11:56:46 AM UTCjean_brefortStatusNone=>Need Info
      Assigned toNone=>jean_brefort

    Back to the top


    Powered by Savane 3.1-cleanup1