bugSimulavr: an AVR simulator - Bugs: bug #25679, Clean up on non-autotools Makefile...

 
 

bug #25679: Clean up on non-autotools Makefile and config.h

Submitted by:  Joel Sherrill <joelsherrill>
Submitted on:  Mon 23 Feb 2009 04:44:26 PM UTC  
 
Category: SimulationSeverity: 2 - Minor
Item Group: NoneStatus: Confirmed
Privacy: PublicAssigned to: Klaus Rudolph <zfrdh>
Open/Closed: ClosedComponent Version: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 04 Mar 2009 03:08:20 PM UTC, comment #3:

the attached files are partly applied. Some minor changes from my side. Builds on my system, but geda/vpi is untested!

Klaus Rudolph <zfrdh>
Project AdministratorIn charge of this item.
Tue 24 Feb 2009 02:24:23 PM UTC, comment #2:

In general, all hard coded paths are now in config.h and
geda is optional.

@@ -11,7 +11,11 @@

Do not always include geda include path. Add it only
if HAVE_GEDA=yes.

Use new variable GEDA from config.h for GEDA prefix.

@@ -22,13 +26,12 @@

Add LIBZ variable and use it when linking executables.

I have no idea about removing "include $(OBJECTS:.o=.d)". It was
in your patch to me.

@@ -89,94 +92,97 @@

use LIBZ when linking executables.

Set BFDOBJECTS based upon new variable from config.h
(BINUTILS_BFD) as shorthand and use variable instead
of hard coded path to reference list of BFD objects.

For config.h, the only part that really matters is:

+
+HAVE_GEDA=no
+GEDA=/home/zfrdh/geda-install/

Which adds the GEDA variable. You can ignore the rest.

Once this is committed, I may have another round of cleanup
and simplification on config.h.

Joel Sherrill <joelsherrill>
Project Administrator
Tue 24 Feb 2009 01:56:00 PM UTC, comment #1:

Need explanation of changes... per line, if possible. Have no idea why we have additional files in structure which are called from Makefile... ??? Wondering!

Klaus Rudolph <zfrdh>
Project AdministratorIn charge of this item.
Mon 23 Feb 2009 04:44:26 PM UTC, original submission:

Hi,

The attached files include my modifications to eliminate some
hard-coded paths in the Makefile and to make it possible to
build when GEDA was not installed. It also includes patches
posted by Klaus Rudolph (http://lists.nongnu.org/archive/html/simulavr-devel/2009-02/msg00014.html).

NOTE: The static libz.a is in the RPM zlib-static in Fedora 10.

2009-02-23 Joel Sherrill <joel.sherrill@oarcorp.com>

* src/Makefile, src/config.h: Clean up hard-coded paths.
Make GEDA optional.

Joel Sherrill <joelsherrill>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17511:  Makefile added by joelsherrill (6KiB - application/octet-stream)
file #17512:  config.h added by joelsherrill (776B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by zfrdh (Posted a comment)
  • -unavailable- added by joelsherrill (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 04 Mar 2009 03:08:20 PM UTCzfrdhStatusNeed Info=>Confirmed
      Open/ClosedOpen=>Closed
    Tue 24 Feb 2009 01:56:00 PM UTCzfrdhCategoryNone=>Simulation
      Severity3 - Normal=>2 - Minor
      StatusNone=>Need Info
      Assigned toNone=>zfrdh
    Mon 23 Feb 2009 04:44:26 PM UTCjoelsherrillAttached File-=>Added Makefile, #17511
      Attached File-=>Added config.h, #17512

    Back to the top


    Powered by Savane 3.1-cleanup1