buglwIP - A Lightweight TCP/IP stack - Bugs: bug #26135, Don’t need to allocate space for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26135: Don’t need to allocate space for link header since already in etharp_hdr.

Submitted by:  Zhenwei Chu <blackfin>
Submitted on:  Thu 09 Apr 2009 02:21:42 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Kieran Mansley <kieranm>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.3.0

Wed 15 Apr 2009 02:37:29 PM UTC, comment #3:

In fact, this is already done: I converted it from PBUF_LINK to PBUF_RAW (saving space, initial post is the other way round, which is wrong) in etharp.c v1.150, 7 weeks ago -> fixed in CVS HEAD but was wrong in 1.3.0.

Kieran, I'll close this, hope it's OK for you as you are the assignee.

Simon Goldschmidt <goldsimon>
Project Administrator
Fri 10 Apr 2009 05:59:19 AM UTC, comment #2:

Please do so. We already talked about that line multiple times and I wanted to change it but I always seem to have forgotten it...

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 09 Apr 2009 02:45:39 PM UTC, comment #1:

Looks good, thanks. I'll apply this unless anyone has any objections.

Kieran Mansley <kieranm>
Project AdministratorIn charge of this item.
Thu 09 Apr 2009 02:21:42 PM UTC, original submission:

Don’t need to allocate space for link header since already in etharp_hdr.

changed
Etharp.c, line1029:
From:
etharp_raw()

/* allocate a pbuf for the outgoing ARP request packet */
/* don't need to allocate space for link header since already in etharp_hdr */
p = pbuf_alloc(PBUF_RAW, sizeof(struct etharp_hdr), PBUF_RAM);

To:
etharp_raw()

/* allocate a pbuf for the outgoing ARP request packet */

p = pbuf_alloc(PBUF_LINK, sizeof(struct etharp_hdr), PBUF_RAM);

Zhenwei Chu <blackfin>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by blackfin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Apr 2009 02:37:29 PM UTCgoldsimonStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 09 Apr 2009 02:45:39 PM UTCkieranmAssigned toNone=>kieranm
      Planned Release=>1.3.1

    Back to the top


    Powered by Savane 3.1-cleanup1