bugTiger UNIX security tool - Bugs: bug #26479, Single quotes around a variable

 
 

bug #26479: Single quotes around a variable

Submitted by:  None
Submitted on:  Thu 07 May 2009 07:53:48 AM UTC  
 
Category: Security check modulesSeverity: 5-Critical
Item Group: Script errorStatus: Fixed
Privacy: PublicAssigned to: Javier Fernandez-Sanguino Peña <jfs>
Open/Closed: ClosedOperating System: All

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 07 Sep 2012 01:58:04 PM UTC, comment #1:

commit f3ff1f4fd395941fef2853cf8b51afc6439838aa
Author: Javier Fernandez-Sanguino <jfs@debian.org>
Date: Thu May 7 21:55:04 2009 +0000

Fixed use of quotes in check_perms (Savannah bug #26479)

Sorry for not closing this bug before. Doing so now.

Javier Fernandez-Sanguino Peña <jfs>
Project AdministratorIn charge of this item.
Thu 07 May 2009 07:53:48 AM UTC, original submission:

The line:

scripts/check_perms:186: [ ! $TESTLINK '$filename' ] && [ -f '$filename' -o -d '$filename' ] &&

will never ever work, there is no file named $filename.

I wold sugeste doublequotes:

scripts/check_perms:186: [ ! $TESTLINK "$filename" ] && [ -f "$filename" -o -d "$filename" ] &&

This line does the job.

Cheers, RPG

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jfs (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 07 Sep 2012 01:58:04 PM UTCjfsStatusNone=>Fixed
      Assigned toNone=>jfs
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1