bugLordsAWar! - Bugs: bug #26892, can vector too many units to a city

 
 

bug #26892: can vector too many units to a city

Submitted by:  Ben Asselstine <benasselstine>
Submitted on:  Thu 25 Jun 2009 10:51:59 PM UTC  
 
Category: gameSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 27 Jun 2009 05:49:21 PM UTC, comment #1:

This bug really is referring to too many cities vectoring to another single city or planted-standard (hero's flag). Some of the changes to the codebase were naming changes that reaffirmed this idea.

The player object's VectorFromCity method didn't check to see if the destination could have another city vectoring to it.

Work was also done on the player object's changeVectorDestination method so that it can support a planted-standard as the source or the destination.

The vectormap object was also changed. Because the player's VectorFromCity method can now fail, the callers of it in the vectormap object needed to handle the case.

It isn't fully tested, and there could still be some vectoring bugs hanging around.

Unrelated to this bug, but also checked in:
I changed the graphics of the production map in a way that is deliberately different from the original game. Now we see enemy shields, alongside the production icons for our own. Also I've added a can't-vector-here production shield icon, that looks a lot like the other production shields but it is primarily red. The original game showed unvectorable-to cities as a razed city.
Also, there is now a white box drawn around the active city.

Another unrelated change is that vector actions are pruned from the player's action list. Imagine a case where you turn the vectoring on and off. The pruning algorithm removes all other vector actions except for the last one.

Ben Asselstine <benasselstine>
Project Administrator
Thu 25 Jun 2009 10:51:59 PM UTC, original submission:

Steps to reproduce:

1. start a new random game with 80 cities, and quick-start turned on.
2. vector more than 4 cities to another city.

Result:

an unlimited number of cities can be vectored another city.

Expected result:

it's supposed to max out at 4.

Ben Asselstine <benasselstine>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by benasselstine (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Jun 2009 05:49:21 PM UTCbenasselstineOpen/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1