buglwIP - A Lightweight TCP/IP stack - Bugs: bug #27155, 'NULL' undeclared in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #27155: 'NULL' undeclared in inet_checksum.c

Submitted by:  Ben Hastings <hastings>
Submitted on:  Sun 02 Aug 2009 09:12:24 AM UTC  
 
Category: IPv4Severity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

(Jump to the original submission Jump to the original submission)

Mon 03 Aug 2009 07:29:08 PM UTC, comment #6:

Fixed.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 03 Aug 2009 10:39:27 AM UTC, comment #5:

Agreed

Kieran Mansley <kieranm>
Project Administrator
Sun 02 Aug 2009 07:03:50 PM UTC, comment #4:

I guess this can still go in to 1.3.1, since it's really not a big change...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sun 02 Aug 2009 06:53:22 PM UTC, comment #3:

I actually just commented out the string.h include in cc.h to test RC2. I was hoping everything would compile cleanley without it, but inet_chksum.c still fails.

Ben Hastings <hastings>
Sun 02 Aug 2009 10:56:31 AM UTC, comment #2:

Perhaps the simplest thing is to add it in your cc.h file (in a first time) with others standards headers files, like string.h, stdlib.h, etc... After all, this is the place where some lwip types are defined, like u8_t, s8_t, u16_t, s16_t, u32_t, s32_t, mem_ptr_t . We could also read in sys_arch.txt : "This file must either include a system-local <errno.h> which defines the standard *nix error codes, or it should #define LWIP_PROVIDE_ERRNO to make lwip/arch.h define the codes which are used throughout."

Of course, it have to be fix in inet_chksum.c, but add these includes in cc.h will avoid you future problems...

Frédéric Bernon <fbernon>
Project Member
Sun 02 Aug 2009 09:23:30 AM UTC, comment #1:

That would be inet_chksum.c, not inet_chksum.h

Ben Hastings <hastings>
Sun 02 Aug 2009 09:12:24 AM UTC, original submission:

It looks like #include <stddef.h> was added to all the files that use size_t, but it also needs to be added to files that don't already have NULL declared. Specifically, inet_chksum.h requires it to compile.

Ben Hastings <hastings>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by fbernon (Posted a comment)
  • -unavailable- added by hastings (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 03 Aug 2009 07:29:08 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1