buglwIP - A Lightweight TCP/IP stack - Bugs: bug #27220, Missing include guardians for sio.h

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #27220: Missing include guardians for sio.h

Submitted by:  Christian Walter <cwalter_at>
Submitted on:  Mon 10 Aug 2009 04:42:52 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.3.0

Tue 11 Aug 2009 11:31:15 AM UTC, comment #4:

I added them 16 months ago, but after 1.3.0.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 11 Aug 2009 10:58:49 AM UTC, comment #3:

They already do though.

Kieran Mansley <kieranm>
Project Administrator
Tue 11 Aug 2009 10:27:32 AM UTC, comment #2:

There should be include guardians like

#ifndef __SIO_H
#define __SIO_H

...

#endif

Christian Walter <cwalter_at>
Tue 11 Aug 2009 08:32:46 AM UTC, comment #1:

Can you explain what you mean by guardians?

Kieran Mansley <kieranm>
Project Administrator
Mon 10 Aug 2009 04:42:52 PM UTC, original submission:

Include guardians should be added to sio.h since it might be included by the devloper wanting to implement the porting layer to get prototypes.

Christian Walter <cwalter_at>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by kieranm (Posted a comment)
  • -unavailable- added by cwalter_at (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 11 Aug 2009 11:31:15 AM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1