buglwIP - A Lightweight TCP/IP stack - Bugs: bug #27858, PPP: missing call to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #27858: PPP: missing call to netif_set_down()

Submitted by:  Iordan Neshev <iordan_neshev>
Submitted on:  Fri 30 Oct 2009 11:48:39 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Thu 10 Dec 2009 03:58:31 PM UTC, comment #3:

Moved the problem from comment #2 to bug #28248.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sun 06 Dec 2009 02:14:27 PM UTC, comment #2:

I've added the call to netif_set_down() in sifdown(), but I still think netif_set_down() should be called from netif_remove().

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 03 Dec 2009 07:58:32 PM UTC, comment #1:

I think this is a more generic problem when working with netif callbacks and it should be solved in netif_remove(), i.e. resetting NETIF_FLAG_UP and calling NETIF_STATUS_CALLBACK() in netif_remove().

It's a sad thing that the (relatively) new netif-callbacks don't have a reason-argument which we can use to indicate that we remove the netif.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 30 Oct 2009 11:48:39 AM UTC, original submission:

This is moved here from patch #6965: PPP improvements.

ppp.c: int sifdown()

> *line 1388: add a function call
>
> pc->if_up = 0;
> netif_set_down(&pc->netif); // <-- this line is missing
> netif_remove(&pc->netif);


The missing function call clears the NETIF_FLAG_UP flag
and calls the status and link callbacks, which
should be present when either (or both)
LWIP_NETIF_STATUS_CALLBACK and/or LWIP_NETIF_LINK_CALLBACK
are defined.

This may be important for the users who use
status & link callbacks + PPP. For me it works,
though the callbacks are dummy.

Should be planned for lwip 1.4

Iordan Neshev <iordan_neshev>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by iordan_neshev (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 Dec 2009 03:58:31 PM UTCgoldsimonOpen/ClosedOpen=>Closed
    Sun 06 Dec 2009 02:14:27 PM UTCgoldsimonAssigned toNone=>goldsimon
      StatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1