bugThe FreeType Project - Bugs: bug #27922, Added basic support for Type1...

 
 

bug #27922: Added basic support for Type1 charstrings in CFF.

Submitted by:  bram tassyns <bramt>
Submitted on:  Tue 03 Nov 2009 08:15:18 AM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.12

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 04 Nov 2009 08:32:10 AM UTC, comment #5:

No, it should look similar to this what I've already added to the ChangeLog file -- if you think the wording can be improved please send me a patch.

In other words, for this change of yours you don't have to do anything :-)

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Wed 04 Nov 2009 08:24:22 AM UTC, comment #4:

Something like this?

  • src/cff/cffgload.c: added basic support for Type1 charstrings in CFF

- correctly compute subr index (Type1 has no bias)
- added seac, sbw and setcurrentpoint operators
- correctly parse 5 byte numbers (Type1 has signed integer instead of 16.16)
- vstem3 and hstem3 are now handled the same way as vstem and hstem
- fixed issue with existing hsbw and callothersubr/pop routines

bram tassyns <bramt>
Wed 04 Nov 2009 06:23:39 AM UTC, comment #3:

Applied, thanks!

Note that you would make my life easier if you could provide a proper ChangeLog entry too...

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 03 Nov 2009 12:36:08 PM UTC, comment #2:

Attached new patch

(file #18983)

bram tassyns <bramt>
Tue 03 Nov 2009 12:31:52 PM UTC, comment #1:

Thanks! However, a plain diff is hard to apply since it doesn't contain any context; please repost with `diff -u'.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 03 Nov 2009 08:15:18 AM UTC, original submission:

Attached is a patch that will add simple support for Type1 charstrings in a CFF font (simple only because existing OtherSubr items are (correctly) ignored, if someone ever wishes this you could actually implement them like it's done for postscript fonts).

This is not really required but the CFF spec makes it possible to construct such fonts.

We don't really create such fonts ourselfs (since most other software can't handle them anyway :)), but we used this code to debug an intermediary phase of our Type1 -> CFF conversion.

bram tassyns <bramt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18983:  Type1InCFF.diff added by bramt (9KiB - application/octet-stream)
file #18982:  CFFTyp1Support.diff added by bramt (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by bramt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 04 Nov 2009 06:23:39 AM UTCwlPlanned ReleaseNone=>2.3.12
      Open/ClosedOpen=>Closed
      StatusNone=>Fixed
    Tue 03 Nov 2009 12:36:08 PM UTCbramtAttached File-=>Added Type1InCFF.diff, #18983
    Tue 03 Nov 2009 12:31:51 PM UTCwlAssigned toNone=>wl
    Tue 03 Nov 2009 08:15:18 AM UTCbramtAttached File-=>Added CFFTyp1Support.diff, #18982

    Back to the top


    Powered by Savane 3.1-cleanup1