buglwIP - A Lightweight TCP/IP stack - Bugs: bug #28127, remove call to tcp_output() from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28127: remove call to tcp_output() from tcp_ack(_now)()

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Mon 30 Nov 2009 06:57:02 AM UTC  
 
Category: TCPSeverity: 1 - Wish
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Sun 10 Jan 2010 11:41:35 AM UTC, comment #2:

Checked in as noone objected.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 01 Dec 2009 05:51:41 PM UTC, comment #1:

I should mention that this won't change the code (after the C preprocessor run, that is), it only affects its readability.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 30 Nov 2009 06:57:02 AM UTC, original submission:

tcp_ack_now() is used 9 times of that only 2 times can result in outputting segments since with all other tcp_input_pcb==pcb is true.

tcp_ack() is only used when tcp_input_pcb==pcb!

For performance and clarity (don't make the developer think tcp_output gets called when it doesn't, effectively), I propose to remove the call to tcp_output() from the tcp_ack(_now) defines and to put an explicit call to tcp_output where it is actually called (and does something) now.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 10 Jan 2010 11:41:35 AM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1