buglwIP - A Lightweight TCP/IP stack - Bugs: bug #28529, macro LWIP_DEBUG_TIMERNAMES in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28529: macro LWIP_DEBUG_TIMERNAMES in timers.h

Submitted by:  hanhui <hanhui03>
Submitted on:  Sat 09 Jan 2010 03:27:40 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Sat 09 Jan 2010 07:15:30 PM UTC, comment #3:

> in lwip source code, use #ifdef LWIP_DEBUG


Ooops, you're right, I forgot that. Thanks for reporting and for following CVS!

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 09 Jan 2010 05:21:54 PM UTC, comment #2:

in lwip source code, use #ifdef LWIP_DEBUG to determine whether to compile for debug mode. but not #if LWIP_DEBUG.

#ifdef LWIP_DEBUG
(check whether the macro LWIP_DEBUG is defined)

#if LWIP_DEBUG
(check LWIP_DEBUG is not equal to 0)

if LWIP_DEBUG is not define,
#define LWIP_DEBUG_TIMERNAMES (LWIP_DEBUG && SYS_DEBUG)
some compilers will generate a warning!
"LWIP_DEBUG is not defined."

#define XXXX 0
IS NOT EQUAL TO
#undef XXXX

hanhui <hanhui03>
Sat 09 Jan 2010 08:37:49 AM UTC, comment #1:

Could you explain what's the difference to the current code (below)? I thought the two version would result in the same...

#ifndef LWIP_DEBUG_TIMERNAMES
#define LWIP_DEBUG_TIMERNAMES (LWIP_DEBUG && SYS_DEBUG)
#endif

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 09 Jan 2010 03:27:40 AM UTC, original submission:

timers.h line 46 should be:

#ifdef LWIP_DEBUG
#define LWIP_DEBUG_TIMERNAMES SYS_DEBUG
#else
#define LWIP_DEBUG_TIMERNAMES 0
#endif

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 09 Jan 2010 07:15:30 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1