bugIdentica mode - Bugs: bug #28561, Making identica-mode backend based...

 
 

bug #28561: Making identica-mode backend based on url.el (with patch)

Submitted by:  Shyam Karanatt <swathanthran>
Submitted on:  Tue 12 Jan 2010 05:48:13 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Shyam Karanatt <swathanthran>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 06 Mar 2010 06:48:14 PM UTC, comment #4:

Thanks Jason. You're right. Turned out to be some kind of error on my setup. So far it has worked for everyone.

Gabriel Saldana <gabrielsaldana>
Project Administrator
Fri 05 Mar 2010 01:33:15 PM UTC, comment #3:

This has been working fine for everyone running git checkouts for a while, so I'm going to close this. Thanks to @swathanthran for the excellent work.

Jason F. McBrayer <jfmcbrayer>
Project Member
Wed 27 Jan 2010 04:56:56 PM UTC, comment #2:

Tried your last patch on the mac using Emacs 23.1.1 2009-08-26 and works without trouble. On the debian testing machine using Emacs-snapshot 23.1.91.1 of 2010-01-25 (orebokech packages) and I get no timeline on the buffer and get the following error messages:

Could not load cookie file /home/gabriel/.url/cookies
Saw end of trailers...
error in process filter: or: Wrong type argument: listp, "statuses"
error in process filter: Wrong type argument: listp, "statuses"
error in process filter: or: Wrong type argument: listp, "statuses"
error in process filter: Wrong type argument: listp, "statuses"
error in process filter: or: Wrong type argument: listp, "statuses"
error in process filter: Wrong type argument: listp, "statuses"

Also tested on debian testing emacs23 and emacs22 having the same results.

Gabriel Saldana <gabrielsaldana>
Project Administrator
Fri 22 Jan 2010 01:17:36 AM UTC, comment #1:

Hi,
A new patch is added which is a better version,
also including some features like minibuffer showing indication on an ongoing network process i.e showing "loading.. " when it loads data from server.

Patch is against the current head and is tested on
emacs22, emacs23 and the latest trunk.
Should be ready for commit if its works on your systems.

Happy Hacking
Shyam k

(file #19527)

Shyam Karanatt <swathanthran>
Project MemberIn charge of this item.
Tue 12 Jan 2010 05:48:13 AM UTC, original submission:

Hi,
Happy to submit this patch which changes the identica-mode's backend from using open-network-stream to using url.el library.
Patch Highlights:
1) Complete rebase to url-http backend.
2) All http communication is now called with url-retrieve providing asynchrnous communication
3) dynamic change of users, interactively using identica-change-user
identica-change-user can be used to set the username and password, which gets its effect on the next command.

Even based on url-retrieve, there is a bug on really poor network connections.
url-retrieve actually checks whether it can parse the headers of the http-response to call the sentinel function. But on slow connections, it often happens that the header will be loaded but the content is not yet complete. So url-retrieve calls the sentinel before the response is completely fetched resulting in parse error.

one natural solution is to check the content-length header on http response. But statusnet response headars does not include (and they said its difficult for them) content-length headers.

The temporary hack i did was to check for \n at the end of the message, which the statusnet responses i checked does have. I'll submit it as another bug when i am ok with the patch.

Happy Hacking
Shyam K

Shyam Karanatt <swathanthran>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19527:  0001-1-Adding-url.el-backend.patch added by swathanthran (25KiB - text/x-diff - Better patch, ready for commit after testing..)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jfmcbrayer (Posted a comment)
  • -unavailable- added by gabrielsaldana (Updated the item)
  • -unavailable- added by swathanthran (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 05 Mar 2010 01:33:15 PM UTCjfmcbrayerStatusWorks For Me=>Fixed
      Open/ClosedOpen=>Closed
    Wed 27 Jan 2010 04:57:46 PM UTCgabrielsaldanaAssigned toNone=>swathanthran
    Fri 22 Jan 2010 01:17:36 AM UTCswathanthranAttached File-=>Added 0001-1-Adding-url.el-backend.patch, #19527
      StatusReady For Test=>Works For Me
    Thu 14 Jan 2010 11:30:39 PM UTCgabrielsaldanaStatusNone=>Ready For Test
    Tue 12 Jan 2010 09:26:01 AM UTCswathanthranAttached File-=>Added 0001-The-Big-Commit.-Changing-the-backend-functions-to-be.patch, #19467
    Tue 12 Jan 2010 05:48:13 AM UTCswathanthranAttached File-=>Added identica-mode_url-http-backend.patch, #19466

    Back to the top


    Powered by Savane 3.1-cleanup1