bugWeeChat - Bugs: bug #28650, Don't show notification in...

 
 

bug #28650: Don't show notification in notify.py plugin when current buffer is notified

Submitted by:  Didier Roche <didrocks>
Submitted on:  Sun 17 Jan 2010 06:00:28 PM UTC  
 
Category: scriptsSeverity: 3 - Normal
Item Group: otherStatus: Invalid
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Open/Closed: Closed
Release: 0.3.0IRC nick: didrocks

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 18 Jan 2010 08:35:18 AM UTC, comment #4:

Please join #weechat on irc.freenode.net, we'll help you with API.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 18 Jan 2010 08:10:19 AM UTC, comment #3:

Btw, in the plugin API, I wasn't able to find how to catch what the current concerned buffer in
weechat.hook_signal("weechat_pv",...,...) function
(it seems to only be available in weechat.hook_print() callback function, which isn't available for private conversation.

Any thought?

Didier Roche <didrocks>
Mon 18 Jan 2010 08:06:26 AM UTC, comment #2:

I've submitted it to you as you've already patch the script, so I was thinking you was having some interest in it:
http://www.weechat.org/files/scripts/notify.py

2009-05-02, FlashCode

But well… hope the author will answer.

Didier Roche <didrocks>
Sun 17 Jan 2010 06:11:43 PM UTC, comment #1:

For support with scripts, please contact scripts author. WeeChat bugs are for core or C plugins only, not scripts (which are third-party contributions).

Feel free to submit updates for scripts if your patch is ok (submit script as a new version, not a patch).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Sun 17 Jan 2010 06:00:28 PM UTC, original submission:

I think that we shouldn't notify with python-notify when the current buffer is the one receiving the notification.

My attached patch fix that and can be applied to "notify" script.

However, I can't get the current private buffer receiving the current message from the API to achieve the same in nofify_show_priv signal.
Would be nice because being spam with notification when you are talking with someone privately is not great. (only the first one, when somebody begins to speak to you, until you really get to the corresponding buffer is needed in my opinion). Any idea on that?

Didier Roche <didrocks>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Posted a comment)
  • -unavailable- added by didrocks (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Jan 2010 09:51:17 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Sun 17 Jan 2010 06:11:43 PM UTCflashcodeCategoryplugins=>scripts
      Item GroupNone=>other
      StatusNone=>Invalid
      Assigned toNone=>flashcode
    Sun 17 Jan 2010 06:00:28 PM UTCdidrocksAttached File-=>Added don_t_show_on_current_buffer.diff, #19506

    Back to the top


    Powered by Savane 3.1-cleanup1