buglwIP - A Lightweight TCP/IP stack - Bugs: bug #28732, struct in_addr conflicts with OS...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28732: struct in_addr conflicts with OS type

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Mon 25 Jan 2010 09:31:31 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Fri 29 Jan 2010 08:27:28 AM UTC, comment #1:

Cleanly separate the portability file inet.h and its contents from the stack: moved htonX-functions to def.h (and the new def.c - they are not ipv4 dependent),let inet.h depend on ip_addr.h and not the other way round.

-> now struct in_addr is only define when explicitly including one of the compatibility api header files, not when including the raw api files.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 25 Jan 2010 09:31:31 AM UTC, original submission:

struct in_addr should not be defined in inet.h or htons/htonl and address defines (none/loopback/any/broadcast) should be moved to another file.

The reason is that inet.h is included in many files to get htons etc. but that defines struct in_addr which might be defined by the OS already (e.g. if compiling the win32 or unix port).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 29 Jan 2010 08:27:28 AM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1