bugBos Wars - Bugs: bug #29010, Rescuing an engineer leads to a...

 
 

bug #29010: Rescuing an engineer leads to a resource drain.

Submitted by:  Kyran <kyran>
Submitted on:  Fri 26 Feb 2010 06:15:01 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: François Beerten <feb>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Apr 2010 09:15:39 PM UTC, comment #3:

Patch applied. Thanks for the report and the fix.

François Beerten <feb>
Project AdministratorIn charge of this item.
Sat 03 Apr 2010 11:03:32 AM UTC, comment #2:

Untested patch attached. This patch does not recompute the recycling efficiency.

First get trunk r9696, then apply file #20101 from bug #29112, and finally apply this patch.

(file #20102)

Kalle Olavi Niemitalo <kon>
Project Member
Sat 03 Apr 2010 10:50:36 AM UTC, comment #1:

GatherResource does this:

I suppose CUnit::ChangeOwner should do something similar.
However... is it possible that changing the owner of the harvester should also change the efficiency in some circumstances? E.g. if the unit was harvesting an allied building originally, but now that you own the unit, the building is no longer allied. If that too must work perfectly, then just transferring the resource production rates to the new owner does not suffice.

Kalle Olavi Niemitalo <kon>
Project Member
Fri 26 Feb 2010 06:15:01 AM UTC, original submission:

When you rescue an engineer that is harvesting a resource its income is not transferred to the new player. This results in a resource drain when said unit ceases harvesting.

Kyran <kyran>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20102:  0001-Transfer-the-resource-production-when-rescuing-a-uni.patch added by kon (2KiB - text/x-patch - [PATCH] Transfer the resource production when rescuing a unit)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by feb (Posted a comment)
  • -unavailable- added by kon (Posted a comment)
  • -unavailable- added by kyran (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Apr 2010 09:15:39 PM UTCfebStatusNone=>Fixed
      Assigned toNone=>feb
      Open/ClosedOpen=>Closed
    Sat 03 Apr 2010 11:03:32 AM UTCkonAttached File-=>Added 0001-Transfer-the-resource-production-when-rescuing-a-uni.patch, #20102

    Back to the top


    Powered by Savane 3.1-cleanup1