bugBos Wars - Bugs: bug #29093, "Buildings" column in...

 
 

bug #29093: "Buildings" column in game-over statistics is too narrow for Finnish translation

Submitted by:  Kalle Olavi Niemitalo <kon>
Submitted on:  Sun 07 Mar 2010 12:58:45 AM UTC  
 
Severity: 2 - MinorItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: François Beerten <feb>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 10 Apr 2010 07:03:48 PM UTC, comment #5:

Comment added to clarify.

François Beerten <feb>
Project AdministratorIn charge of this item.
Tue 06 Apr 2010 05:18:00 AM UTC, comment #4:

Also, the "Move all the widgets to their final positions" loop really must iterate over the columns in the correct order, because of how it increments x. If you used the pairs function there, the order would be unspecified. It is not obvious how menu:adjustColumnwidths should sort column indexes that are not integers.

Please revert r9706.

Kalle Olavi Niemitalo <kon>
Project Member
Tue 06 Apr 2010 04:21:59 AM UTC, comment #3:

The improvement in trunk r9706 is not right. You removed the comment:

-- All keys in these tables must be numbers starting from 1.

and made the loops use ipairs instead of incrementing counters, leaving only two uses of #columnWidths. However, according to <http://www.lua.org/manual/5.1/manual.html#pdf-ipairs> and <http://www.lua.org/manual/5.1/manual.html#2.5.5>, both the ipairs function and the # operator still expect the keys to be numbers starting from 1.

If you wanted to support keys that are not contiguous integers, then you'd have to use pairs instead of ipairs, and I think count the elements yourself instead of using #.

Kalle Olavi Niemitalo <kon>
Project Member
Mon 05 Apr 2010 03:54:54 PM UTC, comment #2:

Applied and improved. Thanks for the patch.

François Beerten <feb>
Project AdministratorIn charge of this item.
Wed 17 Mar 2010 11:47:55 PM UTC, comment #1:

This bug occurs specifically if the resolution is 640x480. Already with 800x600, the "Rakennukset" and "Tapot" words only slightly touch, rather than overlap; but that still looks ugly. With 1024x768, there's a clear gap between the columns.

I'm attaching a patch that automatically computes nice sizes and positions for the columns, based on their contents. With 640x480 in particular, the result looks much better. This patch is for trunk r9686.

(file #19970)

Kalle Olavi Niemitalo <kon>
Project Member
Sun 07 Mar 2010 12:58:45 AM UTC, original submission:

This report applies to trunk r9671.

When you win or lose in a map, Bos Wars displays some statistics with columns titled Player, Units, Buildings, Kills, and Razings. In Finnish, "Buildings" becomes "Rakennukset". This string is too wide to fit in the column; only "Rakennuk" is clearly legible and the rest overlaps the title of the next column.

Please make the column wider so that the title fits. It might be best to check the widths of the titles at run time and then equalize the gaps between them and center the whole thing.

Kalle Olavi Niemitalo <kon>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19970:  0001-Autosize-columns-in-game-over-statistics.patch added by kon (5KiB - text/x-patch - [PATCH] Autosize columns in game-over statistics)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by feb (Posted a comment)
  • -unavailable- added by kon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 10 Apr 2010 07:03:48 PM UTCfebOpen/ClosedOpen=>Closed
    Tue 06 Apr 2010 04:21:59 AM UTCkonOpen/ClosedClosed=>Open
    Mon 05 Apr 2010 03:54:54 PM UTCfebStatusNone=>Fixed
      Assigned toNone=>feb
      Open/ClosedOpen=>Closed
    Wed 17 Mar 2010 11:47:55 PM UTCkonAttached File-=>Added 0001-Autosize-columns-in-game-over-statistics.patch, #19970

    Back to the top


    Powered by Savane 3.1-cleanup1