bugBos Wars - Bugs: bug #29112, Rescuing a building that's...

 
 

bug #29112: Rescuing a building that's constructing a unit results in a crash.

Submitted by:  Kyran <kyran>
Submitted on:  Sun 07 Mar 2010 11:32:25 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: François Beerten <feb>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Apr 2010 08:21:18 PM UTC, comment #5:

Patch applied. Thank you for the report and the fix.

François Beerten <feb>
Project AdministratorIn charge of this item.
Sat 03 Apr 2010 10:41:02 AM UTC, comment #4:

Version 2 of the patch. Now the code matches comments better. I didn't yet test this though.

(file #20101)

Kalle Olavi Niemitalo <kon>
Project Member
Sun 14 Mar 2010 10:10:08 PM UTC, comment #3:

The patch was reverted.

<paakku> feb: I didn't think you'd apply r9685 as such
<paakku> the code was a bit off
<feb> ?
<paakku> the order of things didn't match the comments
<paakku> there was a comment like "now, the target" or something like that
<feb> when applying it I was thinking i'm getting tired and should delay
<paakku> but the resource consumption was transferred before that

François Beerten <feb>
Project AdministratorIn charge of this item.
Sun 14 Mar 2010 09:34:58 PM UTC, comment #2:

Patch applied to the development version.

This is a beautiful map. But you shouldn't define new units and alike in the map. Certainly not in the map presentation file !

François Beerten <feb>
Project AdministratorIn charge of this item.
Sat 13 Mar 2010 04:10:42 AM UTC, comment #1:

File #19925 should fix the crash.

I'm also attaching a patch for Rencampaignmap3.map that removes the unit-type and AI definitions from presentation.smp, which should not have such side effects, I think. Instead, it makes setup.sms load scripts.lua. This requires patch #7116 to the engine. It also renames InitAiScripts to InitAiScripts_rencampaignmap3 so that the function doesn't clash with InitAiScripts defined in scripts/ai.lua, and makes scripts.lua call InitAiScripts_rencampaignmap3 directly.

(file #19927)

Kalle Olavi Niemitalo <kon>
Project Member
Sun 07 Mar 2010 11:32:25 PM UTC, original submission:

I've attached a map I've been working on which displays this problem.

East of the start location is a camp which constructs units. If you rescue this building while it is building a unit BOS Wars will crash.

Kyran <kyran>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20101:  0001-Transfer-the-resource-consumption-when-rescuing-a-un.patch added by kon (2KiB - text/x-patch - [PATCHv2] Transfer the resource consumption when rescuing a unit)
file #19927:  Rencampaignmap3.map.diff added by kon (23KiB - text/x-patch - move side effects of Rencampaignmap3.map from presentation.smp to setup.sms)
file #19925:  0001-Transfer-the-resource-consumption-when-rescuing-a-un.patch added by kon (1KiB - text/x-patch - [PATCH] Transfer the resource consumption when rescuing a unit)
file #19879:  Rencampaignmap3.map.zip added by kyran (17KiB - application/octetstream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by feb (Posted a comment)
  • -unavailable- added by kon (Updated the item)
  • -unavailable- added by kyran (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Apr 2010 08:21:18 PM UTCfebStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sat 03 Apr 2010 10:41:02 AM UTCkonAttached File-=>Added 0001-Transfer-the-resource-consumption-when-rescuing-a-un.patch, #20101
    Sun 14 Mar 2010 10:10:08 PM UTCfebStatusFixed=>In Progress
    Sun 14 Mar 2010 09:34:58 PM UTCfebStatusNone=>Fixed
      Assigned toNone=>feb
    Sat 13 Mar 2010 04:10:42 AM UTCkonAttached File-=>Added Rencampaignmap3.map.diff, #19927
    Sat 13 Mar 2010 03:37:06 AM UTCkonAttached File-=>Added 0001-Transfer-the-resource-consumption-when-rescuing-a-un.patch, #19925
    Sun 07 Mar 2010 11:32:25 PM UTCkyranAttached File-=>Added Rencampaignmap3.map.zip, #19879

    Back to the top


    Powered by Savane 3.1-cleanup1