bugDatabase-driven manual pager suite - Bugs: bug #29318, man-db-2.5.7 build fails when not...

 
 

bug #29318: man-db-2.5.7 build fails when not using GNU_NROFF

Submitted by:  Mike Frysinger <vapier>
Submitted on:  Wed 24 Mar 2010 12:08:45 AM UTC  
 
Category: NoneSeverity: 4 - Important
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Colin Watson <cjwatson>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 24 Mar 2010 11:12:29 AM UTC, comment #1:

Because I actually like bzr, while git makes me want to claw my eyes out to make the pain go away. I'll use git if I have no choice, or if somebody is paying me to do it, but there's no way I'm going to use it for a project I do for fun on my own time. I can't help it that Savannah's bzr integration is a bit broken, but if you add /trunk to the URL it gives you then it should work for command-line checkouts, or you can use the mirror at https://code.launchpad.net/~cjwatson/man-db/trunk ('bzr branch lp:man-db') which also has a working web view.

Thanks for your report; I've fixed it in bzr. If you want to backport it but don't want to use Savannah's bzr repository directly for some reason, http://bazaar.launchpad.net/~cjwatson/man-db/trunk/diff/1206 should have a unified diff in about three hours' time when the mirror next updates.

Wed Mar 24 11:04:46 GMT 2010 Colin Watson <cjwatson@debian.org>

Fix build regression when GNU_NROFF is undefined (Savannah bug
#29318).

* src/man.c (add_col): New function, split out from
make_display_command.
(make_roff_command): Reinstate tbl/col logic here, as by the time
we get to make_display_command we've forgotten whether tbl was
used.
(make_display_command): Remove tbl/col logic, useless here. Use
add_col.

Colin Watson <cjwatson>
Project AdministratorIn charge of this item.
Wed 24 Mar 2010 12:08:45 AM UTC, original submission:

the code in make_display_command() relies on using_tbl when GNU_NROFF isnt defined, but it seems this variable is only defined in the make_roff_command() function ...

this leads to the error:
man.c: In function 'make_display_command':
man.c:1851: error: 'using_tbl' undeclared (first use in this function)
man.c:1851: error: (Each undeclared identifier is reported only once
man.c:1851: error: for each function it appears in.)

i'd check latest sources, but it seems this project is using bzr for some weird reason instead of git, and the view bzr page doesnt work.

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cjwatson (Posted a comment)
  • -unavailable- added by vapier (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 Mar 2010 11:12:29 AM UTCcjwatsonSeverity3 - Normal=>4 - Important
      StatusNone=>Fixed
      Assigned toNone=>cjwatson
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1