bugmonotone - Bugs: bug #29484, mtn rename hits an invariant for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29484: mtn rename hits an invariant for invalid moves

Submitter:  Thomas Keller <tommyd>
Submitted:  Thu 08 Apr 2010 10:16:19 PM UTC
   
 
Category:  working copy Severity:  3 - Normal
Item Group:  incorrect behavior Status:  Fixed
Privacy:  Public Assigned to:  rlevitte
Open/Closed:  Closed
mtn version --full: 

monotone 0.47 (base revision: 58eca89fab6322a14c219fb377eae54e21311986)
Running on          : Darwin 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386
C++ compiler        : GNU C++ version 4.0.1 (Apple Inc. build 5490)
C++ standard library: GNU libstdc++ version 20050421
Boost version       : 1_41
SQLite version      : 3.6.20 (compiled against 3.6.20)
Lua version         : Lua 5.1
PCRE version        : 7.9 2009-04-11 (compiled against 7.9)
Botan version       : 1.8.8 (compiled against 1.8.8)
Changes since base revision:
format_version "1"

new_manifest [69563b5f6cb9e1af6a87aebd6d672e721f646026]

old_revision [58eca89fab6322a14c219fb377eae54e21311986]

  Generated from data cached in the distribution;
  further changes may have been made.

Sun 04 Jul 2010 10:58:07 AM UTC, comment #2: 

Subdir moves are now also detected and handled in 7b3a6be6ed783be2973ee26f5ecf9fd85d67a8af. Merged to mainline.

Thomas Keller <tommyd>
Group administrator
Sat 08 May 2010 08:05:58 PM UTC, comment #1: 

Added a few checks to see if a file to be moved is the same as the destination and have mtn issue a warning when that happens.

This follows the same semantics as ths usual Unix mv(1), and will therefore only warn, not trigger an error and therefore not generate a exit code other than 0.

Richard Levitte <rlevitte>
Group administrator
Thu 08 Apr 2010 10:16:19 PM UTC, original submission:  

Steps to reproduce:

$ mtn mkdir foo
$ mtn ci -m test
$ mtn mv foo foo
mtn: skipping foo, already accounted for in workspace
mtn: fatal: error: roster.cc:723: I(child != nd->children.end())
mtn: this is almost certainly a bug in monotone. [...]

The same invariant is hit when a parent directory is tried to be moved in a child directory.

Thomas Keller <tommyd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rlevitte (Updated the item)
  • -email is unavailable- added by tommyd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-04 tommyd Open/ClosedIn Test Closed
    2010-05-08 rlevitte StatusNone Fixed
        Open/ClosedOpen In Test
    2010-05-08 rlevitte Assigned toNone rlevitte

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code