bugELIM - Bugs: bug #29552, Add an option that a new instant...

 
 

bug #29552: Add an option that a new instant message should transfer you to the freshly created(or existing) chat buffer

Submitted by:  Bozhidar Batsov <bozhidar>
Submitted on:  Wed 14 Apr 2010 12:01:01 PM UTC  
Votes:  1  
 
Category: User Interface (garak.el)Severity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Vivek Dasmohapatra <fledermaus>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 22 Jun 2010 08:37:16 AM UTC, comment #6:

Released.

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Thu 27 May 2010 02:18:00 AM UTC, comment #5:

Ok. I think it may be sufficient to foreground buffers whenever
an outbound message appears in them, since currently user interaction is the only way this can happen.

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Sat 24 Apr 2010 04:40:53 PM UTC, comment #4:

The fix is ok, but I think that the conversation buffer should be switched even in cases that a msg was initiated without the conversation being new. For example one may decide to type "/msg someacc someone" while being in a conversion buffer with someone else. He'd probably expect to be moved to the other conversation no matter is it new or existing. The decision is ultimately yours.

Bozhidar Batsov <bozhidar>
Project Member
Sat 24 Apr 2010 01:20:03 AM UTC, comment #3:

Slightly different logic for testing if the message was
sent by us (is-new should be sufficient: the conversation
buffer is never current when a message arives, the elim
process buffer is, so that's not a useful test).

Also try not to stomp on the current window when displaying new
conversations.

c9c173054eeafeedd00a32e19569872bab98b523

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Thu 15 Apr 2010 08:18:01 PM UTC, comment #2:

I've implemented a more sane solution and I'm attaching a patch for your consideration. Basically the code transfers you to the end of a newly created buffer or to an existing buffer on a new msg sent by you. I personally like this is a default behavior, but you might prefer to add it as an optional. I hope you find the patch(and the code) satisfactory.

(file #20233)

Bozhidar Batsov <bozhidar>
Project Member
Thu 15 Apr 2010 10:37:07 AM UTC, comment #1:

Actually some additional checking is required to see if it was you who created the new buffer. Otherwise you'll get taken to the new buffer if someone else initiates a new conversation with you and that is not desirable

Bozhidar Batsov <bozhidar>
Project Member
Wed 14 Apr 2010 12:01:01 PM UTC, original submission:

Personally I find it intuitive to go to the chat buffer created after I've sent someone an IM. Especially since, there is the strong possibility that I'm about to type more or expect a quick response. IMO this should be Garak's default behavior or a customizable variable. Adding two lines of code seem to implement this "feature". I haven't tested the code that much, but it's pretty straightforward and seem to work just fine. I'm not sending it in the form of a patch since it's that short(and I've not cloned the git repo on this particular PC). Better patch next time :-) I hope you find this idea helpful.

(defun garak-new-conversation (process call call-id status args)
(let ((buffer (garak-conversation-buffer process args t)))
(when (not buffer)
(setq buffer (garak-conversation-buffer process args))
(with-current-buffer buffer
(garak-mode)
(garak-init-local-storage)
(setq garak-elim-process process
garak-account-name (cdr (assoc "account-name" args))
garak-account-uid (cdr (assoc "account-uid" args))
garak-conv-name (cdr (assoc "conv-name" args))
garak-conv-uid (cdr (assoc "conv-uid" args))
garak-im-protocol (cdr (assoc "im-protocol" args)))
(lui-insert (format "%s / %s" garak-account-name garak-conv-name)) ))
(switch-to-buffer buffer) ;; added by me
(goto-char (point-max)) ;; added by me
buffer))

Bozhidar Batsov <bozhidar>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fledermaus (Posted a comment)
  • -unavailable- added by mstevens (I want this feature)
  • -unavailable- added by mstevens (Voted in favor of this item)
  • -unavailable- added by bozhidar (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 1 encouragement so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Jun 2010 08:40:51 AM UTCfledermausOpen/ClosedOpen=>Closed
    Tue 22 Jun 2010 08:37:16 AM UTCfledermausStatusIn Progress=>Fixed
    Thu 27 May 2010 02:18:00 AM UTCfledermausStatusReady For Test=>In Progress
    Thu 15 Apr 2010 08:18:01 PM UTCbozhidarAttached File-=>Added 0001-automatically-go-to-chat-buffer-after-sending-an-IM.patch, #20233
      StatusNone=>Ready For Test
      Assigned toNone=>fledermaus
    Thu 15 Apr 2010 02:22:15 PM UTCmstevensCarbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added mstevens

    Back to the top


    Powered by Savane 3.1-cleanup1