bugBos Wars - Bugs: bug #29579, KillUnitAt expects two arguments,...

 
 

bug #29579: KillUnitAt expects two arguments, but uses more

Submitted by:  Kyran <kyran>
Submitted on:  Sat 17 Apr 2010 12:03:53 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Jimmy Salmon <jsalmon3>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Apr 2010 12:03:53 AM UTC, original submission:

paakku> it looks like KillUnitAt expects to get exactly two arguments, but uses more

<Kyran> is it an easy fix?

<paakku> looks easy, but there are more bugs, instead of KillUnitAt(unit, player, quantity, {x1,y1}, {x2,y2}), the code expects KillUnitAt(unit, player, quantity, {x1,y1,x2,y2}) so, four args rather than five

<Kyran> for consistency with the rest of the scripts it should be {x1,y1}, {x2,y2}

<paakku> hoh, the number-of-arguments check was changed in 2005 to use the LuaCheckArgs macro, but the bug was there before that AFAICT, the original implementation of this function with SIOD or Guile did not have the bug. it was introduced during the conversion to lua

Kyran <kyran>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kyran (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 18 Apr 2010 10:03:08 PM UTCjsalmon3StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Sun 18 Apr 2010 05:21:13 PM UTCjsalmon3StatusNone=>Confirmed
      Assigned toNone=>jsalmon3

    Back to the top


    Powered by Savane 3.1-cleanup1