bugBos Wars - Bugs: bug #29731, Replacing patches in the map...

 
 

bug #29731: Replacing patches in the map editor discards CMapField::Flags set because of units

Submitted by:  Kalle Olavi Niemitalo <kon>
Submitted on:  Sat 01 May 2010 03:42:22 PM UTC  
 
Severity: 4 - ImportantItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: François Beerten <feb>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 16 May 2010 08:26:17 PM UTC, comment #2:

Fixed in trunk r9856.

Kalle Olavi Niemitalo <kon>
Project Member
Sun 16 May 2010 02:13:07 PM UTC, comment #1:

I'm attaching a fix for trunk r9852. This patch depends on patch #7190 v2 1/3, i.e. file #20546.

Kalle Olavi Niemitalo <kon>
Project Member
Sat 01 May 2010 03:42:22 PM UTC, original submission:

Bos Wars trunk r9811 on Debian GNU/Linux testing amd64.

Create a map in the editor, set a plain16 patch at the corner, add a vault unit on top of that, remove the plain16 patch, and add a te5 patch in its place. Then attempt to add another vault that overlaps the first one. The editor allows this even though it shouldn't.

It seems CPatchManager::updateMapFlags just copies the CMapField::Flags from the patch and discards the MapFieldBuilding flag that has been set because of the vault. The vault then no longer blocks those map fields and another vault can be added.

Severity = Important because feb considers this a "bad bug".

Kalle Olavi Niemitalo <kon>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20549:  0001-Preserve-MapFieldLandUnit-etc.-in-CPatchManager.patch added by kon (2KiB - text/x-patch - [PATCH] Preserve MapFieldLandUnit etc. in CPatchManager)

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 16 May 2010 08:26:17 PM UTCkonStatusPatch available=>Fixed
      Open/ClosedOpen=>Closed
    Sun 16 May 2010 02:42:17 PM UTCkonAttached File-=>Added 0001-Preserve-MapFieldLandUnit-etc.-in-CPatchManager.patch, #20549
    Sun 16 May 2010 02:13:07 PM UTCkonDependencies-=>Depends on patch #7190
    Sun 16 May 2010 02:13:06 PM UTCkonStatusNone=>Patch available

    Back to the top


    Powered by Savane 3.1-cleanup1