bugPingus - Bugs: bug #30022, SConscript broken using...

 
 

bug #30022: SConscript broken using with_linuxevdev=0

Submitted by:  None
Submitted on:  Tue 01 Jun 2010 03:49:09 AM UTC  
 
Category: General StuffSeverity: 3 - Normal
Item Group: Installation ProblemStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: SVN
Operating System: AllPlanned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 01 Jun 2010 03:50:36 AM UTC, comment #1:

Sorry, I thought I was logged in when I submitted the bug.

Benn Newman <newmanbe>
Tue 01 Jun 2010 03:49:09 AM UTC, original submission:

SConscript has two problems with building without evdev support:

1) reports += " * Linux evdev support: disabled\n" # should be self.reports

2) Scons still attempts to build the tests for evdev, even if evdev support is disabled; this fails on NetBSD (and other systems, I imagine) even though the pingus still otherwise works.

SConscript.patch fixes the first problem.

The second problem can be changed by changing (line 343)

for filename in Glob("test/*_test.cpp", strings=True):
self.env.Program(filename[:-4], [filename, libpingus])

to something like

for filename in Glob("test/*_test.cpp", strings=True):
if(self.config_h_defines != ('HAVE_LINUXEVDEV', 1) and filename != 'test/evdev_device_test.cpp)
self.env.Program(filename[:-4], [filename, libpingus])

but I do not understand Python and scons enough to know exactly what. (I just commented out those two lines.)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20669:  SConscript.patch added by None (520B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by grumbel (Updated the item)
  • -unavailable- added by newmanbe (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 31 Aug 2011 10:27:31 AM UTCgrumbelStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 01 Jun 2010 03:49:09 AM UTCNoneAttached File-=>Added SConscript.patch, #20669

    Back to the top


    Powered by Savane 3.1-cleanup1