buglwIP - A Lightweight TCP/IP stack - Bugs: bug #30129, struct _ip_addr should be struct...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30129: struct _ip_addr should be struct ip_addr

Submitted by:  Bill Auerbach <billauerbach>
Submitted on:  Mon 14 Jun 2010 05:49:50 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Mon 14 Jun 2010 07:53:25 PM UTC, comment #1:

I agree. While developing the changes was easier with the underscore, leaving it away makes updating to 1.4.0 easier.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 14 Jun 2010 05:49:50 PM UTC, original submission:

Adding the leading underscore breaks a lot of existing code unnecessarily. This struct and typedef can be:

struct ip_addr {
u32_t addr;
};

and

typedef struct ip_addr ip_addr_t;

As the typedef and struct are synonymous it can be as above without breaking code but allowing the cleaner typedef to also be used in application code and as it is now in lwIP 1.4

Bill Auerbach <billauerbach>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by billauerbach (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Jun 2010 07:53:25 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1