bugmonotone - Bugs: bug #30150, annotate broken for files with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30150: annotate broken for files with revisions signed by disliked signers

Submitted by:  4get <forget>
Submitted on:  Wed 16 Jun 2010 06:30:37 AM UTC  
 
Category: command line UISeverity: 3 - Normal
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: Thomas Keller <tommyd>
Open/Closed: Closed
mtn version --full: 

mtn-0.48

Sun 27 Jun 2010 07:21:25 PM UTC, comment #1:

fixed in ffed149ff169f774c82597d42ffc2f75f605cae6

Thomas Keller <tommyd>
Project AdministratorIn charge of this item.
Wed 16 Jun 2010 06:30:37 AM UTC, original submission:

mtn annotate fails with error message "misuse: unrecognized date (monotone only understands ISO 8601 format)" when trying to dump revisions signed by signers that are not on the trusted list.

Also revisions before 758da9215e79f1580611a92853def8e5430e00a5 were broken in a nonfatal way - mtn just printed empty strings in <author> and <date> fields.

Bug location:
annotate.cc / build_revisions_to_annotations(..)

Bug sequence:
project.db.erase_bogus_certs(..) kills untrusted certificates,
cert_date_value(..) fails to locate untrusted certificate and tries to format an empty timestamp string.

Steps to reproduce:

1) setup monotonerc with the following trust list http://www.i2p2.de/license-agreements.html
2) mtn --db=i2p.mtn db init
3) mtn --db=i2p.mtn pull mtn.i2p-projekt.de i2p.i2p
4) mtn --db=i2p.mtn --branch=i2p.i2p checkout
5) cd i2p.i2p
6) mtn annotate apps/routerconsole/locale/messages_de.po

mtn would warn about 1 disliked signer on revision 136dff2bda139907eb30f0ec7d7bba09313bc829
and fail with "misuse: unrecognized date (monotone only understands ISO 8601 format)"

4get <forget>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tommyd (Posted a comment)
  • -unavailable- added by forget (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 27 Jun 2010 07:21:25 PM UTCtommydStatusNone=>Fixed
      Assigned toNone=>tommyd
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1