bugThe FreeType Project - Bugs: bug #30220, NULL-ptr deref in bdf/bdflib.c :...

 
 

bug #30220: NULL-ptr deref in bdf/bdflib.c : _bdf_parse_glyphs

Submitted by:  Robert Swiecki <jagger>
Submitted on:  Tue 22 Jun 2010 04:22:04 PM UTC  
 
Severity: 3 - NormalItem Group: Crash
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.13

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Jun 2010 08:01:39 AM UTC, comment #1:

Fixed in git, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 22 Jun 2010 04:22:04 PM UTC, original submission:

gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5), compiled with "-m32 -O0 -g"

Might be related to: https://savannah.nongnu.org/bugs/index.php?30135 (or not;)

Font: http://alt.swiecki.net/j/f/sigsegv12.bdf

$ gdb ./ftbench
(gdb) r -c 1 sigsegv12.bdf

Program received signal SIGSEGV, Segmentation fault.
0x08084d9c in _bdf_parse_glyphs (line=0x80d5306 "ff", linelen=2, lineno=48, call_data=0xffffd83c, client_data=0x80d3078) at /usr/local/google/src/freetype2/src/bdf/bdflib.c:1707
1707 *bp &= nibble_mask[mask_index];

(gdb) p bp
$1 = (unsigned char *) 0x0

(gdb) bt
#0 0x08084d9c in _bdf_parse_glyphs (line=0x80d5306 "ff", linelen=2, lineno=48, call_data=0xffffd83c, client_data=0x80d3078) at /usr/local/google/src/freetype2/src/bdf/bdflib.c:1707
#1 0x080835ee in _bdf_readstream (stream=0x80d2dd0, callback=0x8085878 <_bdf_parse_start>, client_data=0x80d3078, lno=0xffffd87c) at /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
#2 0x0808618c in bdf_load_font (stream=0x80d2dd0, extmemory=0x80ce008, opts=0xffffd8c0, font=0xffffd8f8) at /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
#3 0x08086f99 in BDF_Face_Init (stream=0x80d2dd0, bdfface=0x80d2e00, face_index=0, num_params=0, params=0x0) at /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
#4 0x0804d0c6 in open_face (driver=0x80d2980, stream=0x80d2dd0, face_index=0, num_params=0, params=0x0, aface=0xffffd9c8) at /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
#5 0x0804e331 in FT_Open_Face (library=0x80ce020, args=0xffffda00, face_index=0, aface=0xffffdadc) at /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
#6 0x0804d1bb in FT_New_Face (library=0x80ce020, pathname=0xffffdd0e "sigsegv12.bdf", face_index=0, aface=0xffffdadc) at /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
#7 0x08049995 in get_face (face=0xffffdadc) at /usr/local/google/src/freetype2-demos/src/ftbench.c:615
#8 0x08049c5b in main (argc=1, argv=0xffffdba0) at /usr/local/google/src/freetype2-demos/src/ftbench.c:739

$ valgrind ./ftbench -c 1 sigsegv12.bdf
VALGRIND_MEMORY_LIMIT_IN_MB=4095; VALGRIND_TIMEOUT=3600
==10177== Memcheck, a memory error detector
==10177== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al.
==10177== Using Valgrind-3.6.0.SVN and LibVEX; rerun with -h for copyright info
==10177== Command: ./ftbench -c 1 sigsegv12.bdf
==10177==
==10177== Invalid read of size 8
==10177== at 0x6C9147F: __strlen_sse2 /build/buildd/eglibc-2.11.1/string/../sysdeps/i386/i686/multiarch/strlen.S:106
==10177== by 0x8085E7B: _bdf_parse_start /usr/local/google/src/freetype2/src/bdf/bdflib.c:2153
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177== by 0x804D1BA: FT_New_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
==10177== by 0x8049994: get_face /usr/local/google/src/freetype2-demos/src/ftbench.c:615
==10177== by 0x8049C5A: main /usr/local/google/src/freetype2-demos/src/ftbench.c:739
==10177== Address 0x6d86c90 is 80 bytes inside a block of size 81 alloc'd
==10177== at 0x47DE0D8: malloc /tmp/vg/coregrind/m_replacemalloc/vg_replace_malloc.c:236
==10177== by 0x80B39C4: ft_alloc /usr/local/google/src/freetype2/builds/unix/ftsystem.c:102
==10177== by 0x8054EB9: ft_mem_qalloc /usr/local/google/src/freetype2/src/base/ftutil.c:76
==10177== by 0x8054E53: ft_mem_alloc /usr/local/google/src/freetype2/src/base/ftutil.c:55
==10177== by 0x8055005: ft_mem_qrealloc /usr/local/google/src/freetype2/src/base/ftutil.c:145
==10177== by 0x8054F23: ft_mem_realloc /usr/local/google/src/freetype2/src/base/ftutil.c:101
==10177== by 0x8085E35: _bdf_parse_start /usr/local/google/src/freetype2/src/bdf/bdflib.c:2147
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177==
==10177== Invalid read of size 8
==10177== at 0x6C91470: __strlen_sse2 /build/buildd/eglibc-2.11.1/string/../sysdeps/i386/i686/multiarch/strlen.S:99
==10177== by 0x8085E7B: _bdf_parse_start /usr/local/google/src/freetype2/src/bdf/bdflib.c:2153
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177== by 0x804D1BA: FT_New_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
==10177== by 0x8049994: get_face /usr/local/google/src/freetype2-demos/src/ftbench.c:615
==10177== by 0x8049C5A: main /usr/local/google/src/freetype2-demos/src/ftbench.c:739
==10177== Address 0x6d86de8 is 8 bytes inside a block of size 10 alloc'd
==10177== at 0x47DE0D8: malloc /tmp/vg/coregrind/m_replacemalloc/vg_replace_malloc.c:236
==10177== by 0x80B39C4: ft_alloc /usr/local/google/src/freetype2/builds/unix/ftsystem.c:102
==10177== by 0x8054EB9: ft_mem_qalloc /usr/local/google/src/freetype2/src/base/ftutil.c:76
==10177== by 0x8054E53: ft_mem_alloc /usr/local/google/src/freetype2/src/base/ftutil.c:55
==10177== by 0x8055005: ft_mem_qrealloc /usr/local/google/src/freetype2/src/base/ftutil.c:145
==10177== by 0x8054F23: ft_mem_realloc /usr/local/google/src/freetype2/src/base/ftutil.c:101
==10177== by 0x8085E35: _bdf_parse_start /usr/local/google/src/freetype2/src/bdf/bdflib.c:2147
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177==
==10177== Invalid read of size 8
==10177== at 0x6D379ED: __strcmp_ssse3 /build/buildd/eglibc-2.11.1/string/../sysdeps/i386/i686/multiarch/strcmp-ssse3.S:144
==10177== by 0x8082DAA: hash_lookup /usr/local/google/src/freetype2/src/bdf/bdflib.c:322
==10177== by 0x8084184: _bdf_add_property /usr/local/google/src/freetype2/src/bdf/bdflib.c:1317
==10177== by 0x808577A: _bdf_parse_properties /usr/local/google/src/freetype2/src/bdf/bdflib.c:1958
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177== by 0x804D1BA: FT_New_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
==10177== by 0x8049994: get_face /usr/local/google/src/freetype2-demos/src/ftbench.c:615
==10177== by 0x8049C5A: main /usr/local/google/src/freetype2-demos/src/ftbench.c:739
==10177== Address 0x6d87010 is 16 bytes inside a block of size 18 alloc'd
==10177== at 0x47DE0D8: malloc /tmp/vg/coregrind/m_replacemalloc/vg_replace_malloc.c:236
==10177== by 0x80B39C4: ft_alloc /usr/local/google/src/freetype2/builds/unix/ftsystem.c:102
==10177== by 0x8054EB9: ft_mem_qalloc /usr/local/google/src/freetype2/src/base/ftutil.c:76
==10177== by 0x8054E53: ft_mem_alloc /usr/local/google/src/freetype2/src/base/ftutil.c:55
==10177== by 0x8055005: ft_mem_qrealloc /usr/local/google/src/freetype2/src/base/ftutil.c:145
==10177== by 0x8054F23: ft_mem_realloc /usr/local/google/src/freetype2/src/base/ftutil.c:101
==10177== by 0x8083B16: bdf_create_property /usr/local/google/src/freetype2/src/bdf/bdflib.c:999
==10177== by 0x808415F: _bdf_add_property /usr/local/google/src/freetype2/src/bdf/bdflib.c:1314
==10177== by 0x808577A: _bdf_parse_properties /usr/local/google/src/freetype2/src/bdf/bdflib.c:1958
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177==
==10177== Invalid read of size 1
==10177== at 0x8084D9C: _bdf_parse_glyphs /usr/local/google/src/freetype2/src/bdf/bdflib.c:1707
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177== by 0x804D1BA: FT_New_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
==10177== by 0x8049994: get_face /usr/local/google/src/freetype2-demos/src/ftbench.c:615
==10177== by 0x8049C5A: main /usr/local/google/src/freetype2-demos/src/ftbench.c:739
==10177== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==10177==
==10177==
==10177== Process terminating with default action of signal 11 (SIGSEGV)
==10177== Access not within mapped region at address 0x0
==10177== at 0x8084D9C: _bdf_parse_glyphs /usr/local/google/src/freetype2/src/bdf/bdflib.c:1707
==10177== by 0x80835ED: _bdf_readstream /usr/local/google/src/freetype2/src/bdf/bdflib.c:721
==10177== by 0x808618B: bdf_load_font /usr/local/google/src/freetype2/src/bdf/bdflib.c:2253
==10177== by 0x8086F98: BDF_Face_Init /usr/local/google/src/freetype2/src/bdf/bdfdrivr.c:366
==10177== by 0x804D0C5: open_face /usr/local/google/src/freetype2/src/base/ftobjs.c:1110
==10177== by 0x804E330: FT_Open_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1995
==10177== by 0x804D1BA: FT_New_Face /usr/local/google/src/freetype2/src/base/ftobjs.c:1172
==10177== by 0x8049994: get_face /usr/local/google/src/freetype2-demos/src/ftbench.c:615
==10177== by 0x8049C5A: main /usr/local/google/src/freetype2-demos/src/ftbench.c:739

Robert Swiecki <jagger>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20792:  sigsegv12.bdf added by jagger (15KiB - application/x-font-bdf)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by jagger (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Jun 2010 08:01:39 AM UTCwlStatusNone=>Fixed
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.13
    Tue 22 Jun 2010 04:22:04 PM UTCjaggerAttached File-=>Added sigsegv12.bdf, #20792

    Back to the top


    Powered by Savane 3.1-cleanup1