bugLordsAWar! - Bugs: bug #30522, Patches from FreeBSD package

 
 

bug #30522: Patches from FreeBSD package

Submitted by:  None
Submitted on:  Thu 22 Jul 2010 06:05:53 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: 0.1.9Status: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 23 Jul 2010 12:46:12 PM UTC, comment #3:

libtar's open call wouldn't return a proper error code, so I had to make my own "check" method to see if it's a tarball or not.

I picked "ustar " because that's how libtar and gnu tar did it. At the time it seemed important to be more rigorous and specific, than lenient. If bsdtar puts a \0 in there, that's fine.

I guess it's my way of enforcing the format of lordsawar files.

Does the ustar check really need to be there? no, probably not.

Ben Asselstine <benasselstine>
Project Administrator
Fri 23 Jul 2010 11:26:34 AM UTC, comment #2:

Mail to port's maintainer: -unavailable-

Is check in tarhelper.cpp needed at all? libtar does internal format verification.

Anonymous
Fri 23 Jul 2010 09:27:30 AM UTC, comment #1:

Thanks for the patch. Would you mind including your name in future patches instead of being "anonymous"? It would be nice to know who to email in advance of a release.

Thanks in particular for the cflags/CFLAGS bug!

I won't be changing the long options to short options, nor will I be changing /bin/bash to /bin/sh. I simply prefer the GNU way of doing things.

I've changed the check in tarhelper.cpp to check for magic that starts with "ustar", instead of having two different checks.

Thanks for your continued interest in lordsawar.

Ben Asselstine <benasselstine>
Project Administrator
Thu 22 Jul 2010 06:05:53 PM UTC, original submission:

configure.ac:
- skip path while checking $CC/$CXX, add check for c++
(its can be /usr/local/bin/c++ or even /usr/local/libexec/ccache/cc)
- fix case on ac_save_* variables
(CFLAGS saved to ac_save_cflags but restored from ac_save_CFLAGS)
- change ${parameter/pattern/string} to eval

create-lw-file:
- change /bin/bash to POSIX /bin/sh
- change mktemp's nonstandart --quiet --directory to -q -d

src/tarhelper.cpp:
- create-lw-file creates tar archives with help of native tar.
In case of freebsd this is bsdtar who create archives in POSIX tar
format by default. But this is not a problem, because libtar understands
both formats.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21036:  patch.txt added by None (2KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by benasselstine (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 23 Jul 2010 09:27:30 AM UTCbenasselstineItem GroupNone=>0.1.9
      Open/ClosedOpen=>Closed
    Thu 22 Jul 2010 06:05:53 PM UTCNoneAttached File-=>Added patch.txt, #21036

    Back to the top


    Powered by Savane 3.1-cleanup1