bugµracoli - Bugs: bug #30527, radio_param_t no longer compiles...

 
 

bug #30527: radio_param_t no longer compiles for C++

Submitted by:  Joerg Wunsch <joerg_wunsch>
Submitted on:  Fri 23 Jul 2010 06:41:53 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Joerg Wunsch <joerg_wunsch>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 23 Jul 2010 07:48:15 AM UTC, comment #3:

Fixed in rev 1.20. The change from rev 1.16 was apparently
just made accidentally (perhaps inadvertently together with
a change in a different file).

The second error (bottom of the message shown below) was that
one cannot have to constructors with the same parameter list;
as the actual element names are unimportant (it's a union),
re-use the constructor for cca_mode also for data_rate.

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Fri 23 Jul 2010 07:40:33 AM UTC, comment #2:

I tried the following resolution, which is not that elegant
as:

typdef union radio_param_t
{
....
} radio_param_t;

but it could eliminate the hazard that it is removed later on again:

union radio_param_u
{
channel_t channel;
...

#if defined __cplusplus
radio_param_u(int8_t c) { channel = c; }
...
#endif
};

typedef union radio_param_u radio_param_t;

Axel Wachtler <awachtler>
Project Administrator
Fri 23 Jul 2010 06:44:29 AM UTC, comment #1:

First analysis shows that rev 1.16 of Src/Lib/Inc/radio.h
appears to be the culprit:

The changelog entry says: "removed typo", so the question is:
why was this assumed to be a "typo"? Did something break
when the "radio_param_t" was still there?

When I wrote that, I tested it against both, C and C++, and
everything appeared to be fine.

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Fri 23 Jul 2010 06:41:53 AM UTC, original submission:

uracolix wrote:

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by awachtler (Posted a comment)
  • -unavailable- added by joerg_wunsch (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 23 Jul 2010 07:48:15 AM UTCjoerg_wunschStatusNone=>Fixed
      Assigned toNone=>joerg_wunsch
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1