bugWeeChat - Bugs: bug #30602, display chokes on messages...

 
 

bug #30602: display chokes on messages containing tab-characters

Submitted by:  Nicolai Lissner <blackpenguin>
Submitted on:  Fri 30 Jul 2010 03:20:22 PM UTC  
 
Category:  display Severity:  3 - Normal
Item Group:  display Status:  Fixed
Privacy:  Public Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Open/Closed:  Closed
Release:  0.3.2 IRC nick:  blackpenguin

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 31 Jul 2010 01:01:02 AM UTC, comment #1:

More info collected about this problem and how to reproduce it:

The additional chars appearing have their source in the line above, and this is also the reason why it wasn't easy to reproduce in tests... as a test channel doesn't scroll.
it needs scrolling to appear. Interesting enough, these letters "drop down" not at the position of the tab itself, but the next non-tab whitespace (" " or even \n), so receiving

foo\tbar
results in: foobar<LETTER AT 7th POSITION ONE LINE ABOVE>

foo\t bar

so the problem should be found in the scrolling code, not the code that prints the message.

Nicolai Lissner <blackpenguin>
Fri 30 Jul 2010 03:20:22 PM UTC, original submission:

another user pasted something containing tabs into, the complete message as shown in raw log:
:deki!~reiner@pdpc/supporter/student/cacert.assurer.deki PRIVMSG #nethack.de :95�9 �9static const char explodes[] = "radiates explosive energy"; /* EN static const char explodes[] = "radiates explosive energy"; */ // TODO DE 95�9static const char explodes[] = "radiates explosive energy";

showed up as:

"95u statici const char explode....."

the buffer gets fixed once ctrl-l is pressed.

another weechat user even saw the "i" changing to "h" sometimes when new lines appear in the channel, so the tab completely confused weechat

Proposed solution: simply replace tabs with a configurable amount of spaces?

Nicolai Lissner <blackpenguin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by blackpenguin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-07 flashcode Open/ClosedOpen => Closed
    2010-08-06 flashcode CategoryNone => display
        Item GroupNone => display
        StatusNone => Fixed
        Assigned toNone => flashcode
        Release2.4-dev => 0.3.2

    Back to the top


    Powered by Savane 3.4