bugAVR C Runtime Library - Bugs: bug #30757, CPU_t not implemented in iox128a1.h

 
 

bug #30757: CPU_t not implemented in iox128a1.h

Submitted by:  Ragnar Ranøyen Homb <ragnar>
Submitted on:  Thu 12 Aug 2010 12:34:58 PM UTC  
 
Category: HeaderSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Header files
Status: DuplicatePercent Complete: 0%
Assigned to: Anitha Boyapati <aboyapati>Open/Closed: Closed
Release: 1.6.7Fixed Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 23 Sep 2010 04:26:16 AM UTC, comment #5:

Hi Anitha,

Actually, IIRC, I asked you to just remove those definitions from the header file. Also, IIRC, the registers that would normally be in the CPU_t and GPIO_t structures are defined as "global" registers, meaning that they should not be buried in a structure of registers anywhere.

Also, if this bug is marked as a Duplicate, then go ahead and set the bug to Closed.

Eric

Eric Weddington <arcanum>
Project Administrator
Wed 22 Sep 2010 12:50:47 PM UTC, comment #4:

Firstly, sorry for not responding earlier. I think I missed this bug.

The bug28901 talks about missing CPU_t and GPIO_t definitions only. I think definitions for CPU and GPIO should not have been removed. Upon that I created the patch in the first place!

My fix for this would look something like below (taken only for iox128a1.h). Please review if this looks fine. I shall extend it to rest of xmega header files.

Index: iox128a1.h
===================================================================
--- iox128a1.h (revision 2187)
+++ iox128a1.h (working copy)
@@ -2552,12 +2552,13 @@
IO Module Instances. Mapped to memory.
==========================================================================
*/
-
+#define GPIO (0x0000) /* General Purpose IO Registers */
#define VPORT0 ((VPORT_t ) 0x0010) /* Virtual Port 0 */
#define VPORT1 ((VPORT_t ) 0x0014) /* Virtual Port 1 */
#define VPORT2 ((VPORT_t ) 0x0018) /* Virtual Port 2 */
#define VPORT3 ((VPORT_t ) 0x001C) /* Virtual Port 3 */
#define OCD ((OCD_t ) 0x002E) /* On-Chip Debug System */
+#define CPU (0x0030) /* CPU Registers */
#define CLK ((CLK_t ) 0x0040) /* Clock System */
#define SLEEP ((SLEEP_t ) 0x0048) /* Sleep Controller */
#define OSC ((OSC_t ) 0x0050) /* Oscillator Control */

Anitha Boyapati <aboyapati>In charge of this item.
Thu 12 Aug 2010 01:24:04 PM UTC, comment #3:

This appears to be intentional:

r2116 | aboyapati | 2010-04-06 05:57:30 +0200 (Tue, 06 Apr 2010) | 20 lines

2010-03-31 Anitha Boyapati <anitha.boyapati@atmel.com>

Fix bug #28901.
* include/avr/iox128a1.h - Removed GPIO and CPU memory map entries.
* include/avr/iox128a1u.h - Same.
* include/avr/iox128a3.h - Same.
* include/avr/iox128d3.h - Same.
* include/avr/iox16a4.h - Same.
* include/avr/iox16d4.h - Same.
* include/avr/iox192a3.h - Same.
* include/avr/iox192d3.h - Same.
* include/avr/iox256a3.h - Same.
* include/avr/iox256a3b.h - Same.
* include/avr/iox256d3.h - Same.
* include/avr/iox32a4.h - Same.
* include/avr/iox32d4.h - Same.
* include/avr/iox64a1.h - Same.
* include/avr/iox64a3.h - Same.
* include/avr/iox64d3.h - Same.

Maybe Anitha can comment on why they are not supposed to be
present.

Joerg Wunsch <joerg_wunsch>
Project Administrator
Thu 12 Aug 2010 01:13:27 PM UTC, comment #2:

With the new iox128a1.h (from 1.7.0) i get the error:
... 'CPU' undeclared ...
when trying to access CPU.CPP

Ragnar Ranøyen Homb <ragnar>
Thu 12 Aug 2010 12:38:10 PM UTC, comment #1:

This appears to be a duplicate for bug #28901 which has
been fixed in version 1.7.0.

Please confirm that this version actually fixes also your
problem.

Joerg Wunsch <joerg_wunsch>
Project Administrator
Thu 12 Aug 2010 12:34:58 PM UTC, original submission:

The headerfile iox128a1.h is missing typedef for CPU_t.
Compile error:
'CPU_t' undeclared
when trying to write to CPU.CCP

Ragnar Ranøyen Homb <ragnar>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by arcanum (Posted a comment)
  • -unavailable- added by aboyapati (Posted a comment)
  • -unavailable- added by joerg_wunsch (Posted a comment)
  • -unavailable- added by ragnar (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Sep 2010 03:26:32 PM UTCaboyapatiOpen/ClosedOpen=>Closed
    Thu 12 Aug 2010 12:38:10 PM UTCjoerg_wunschStatusNone=>Duplicate
      Assigned toNone=>aboyapati

    Back to the top


    Powered by Savane 3.1-cleanup1