bugELIM - Bugs: bug #31372, being very mean to elim-client

 
 

bug #31372: being very mean to elim-client

Submitted by:  Michael Stevens <mstevens>
Submitted on:  Tue 19 Oct 2010 02:40:34 PM UTC  
 
Category: libpurple client/daemon (elim-client)Severity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Vivek Dasmohapatra <fledermaus>
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 12 Nov 2010 04:08:45 PM UTC, comment #7:

Thanks. merging.

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Thu 11 Nov 2010 01:38:47 PM UTC, comment #6:

I wasn't actually complaining about the exit, just noting the behaviour as a good tester :)

Michael Stevens <mstevens>
Project Member
Thu 11 Nov 2010 01:37:46 PM UTC, comment #5:

The exit(1) is deliberate, after a certain number of NULs
it's safe to assume the thing talking to you is not well constructed. Will fix the build warning.

I can take out the exit, I tested without it and all that happens is the process logs a bunch of nonsensically named unhandled
s-expressions.

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Thu 11 Nov 2010 10:57:56 AM UTC, comment #4:

Testing this branch:

mstevens@mstevens-desktop:~/elim % ./elim-client </dev/urandom
51 NULs in input, abort.

During build:

cc -Wall -g -O2 -std=c99 -D_GNU_SOURCE -DHAS_ADD_SECONDS -DHAS_QUEUE_INIT -DHAS_GET_HASH_KEYS -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libpurple -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -c -o xnode/xnode.o xnode/xnode.c
xnode/xnode.c: In function ‘xnode_first_child_tag’:
xnode/xnode.c:37: warning: value computed is not used

Michael Stevens <mstevens>
Project Member
Thu 11 Nov 2010 02:41:14 AM UTC, comment #3:

http://git.savannah.gnu.org/cgit/elim.git/log/?h=garbage-filter

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Mon 08 Nov 2010 05:42:56 PM UTC, comment #2:

Well… it's not at the top of my list or anything, but
I'll have another look and see if there are any easy
wins I hadn't thought of before.

Vivek Dasmohapatra <fledermaus>
Project AdministratorIn charge of this item.
Mon 08 Nov 2010 03:54:27 PM UTC, comment #1:

I thought you were going to give up on this one :)

Michael Stevens <mstevens>
Project Member
Tue 19 Oct 2010 02:40:34 PM UTC, original submission:

mstevens@mstevens-desktop:~/elim % ./elim-client </dev/urandom
zsh: segmentation fault (core dumped) ./elim-client < /dev/urandom

Core was generated by `./elim-client'.
Program terminated with signal 11, Segmentation fault.
#0 0x0804e1cd in xnode_first_child_tag ()
(gdb) bt
#0 0x0804e1cd in xnode_first_child_tag ()
#1 0x0804d5cf in sexp_handler ()
#2 0x0024ce5b in ?? () from /lib/libglib-2.0.so.0
#3 0x00205855 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#4 0x00209668 in ?? () from /lib/libglib-2.0.so.0
#5 0x00209ba7 in g_main_loop_run () from /lib/libglib-2.0.so.0
#6 0x0804d965 in main ()

Michael Stevens <mstevens>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fledermaus (Updated the item)
  • -unavailable- added by mstevens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 12 Nov 2010 04:08:44 PM UTCfledermausStatusReady For Test=>Fixed
    Thu 11 Nov 2010 02:41:14 AM UTCfledermausStatusIn Progress=>Ready For Test
    Mon 08 Nov 2010 03:30:05 PM UTCfledermausStatusNone=>In Progress
      Assigned toNone=>fledermaus

    Back to the top


    Powered by Savane 3.1-cleanup1