(
Jump to the original submission)
Fri 12 Nov 2010 04:08:45 PM UTC, comment #7:
Thanks. merging.
|
Thu 11 Nov 2010 01:38:47 PM UTC, comment #6:
I wasn't actually complaining about the exit, just noting the behaviour as a good tester :)
|
Thu 11 Nov 2010 01:37:46 PM UTC, comment #5:
The exit(1) is deliberate, after a certain number of NULs
it's safe to assume the thing talking to you is not well constructed. Will fix the build warning.
I can take out the exit, I tested without it and all that happens is the process logs a bunch of nonsensically named unhandled
s-expressions.
|
Thu 11 Nov 2010 10:57:56 AM UTC, comment #4:
Testing this branch:
mstevens@mstevens-desktop:~/elim % ./elim-client </dev/urandom
51 NULs in input, abort.
During build:
cc -Wall -g -O2 -std=c99 -D_GNU_SOURCE -DHAS_ADD_SECONDS -DHAS_QUEUE_INIT -DHAS_GET_HASH_KEYS -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libpurple -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -c -o xnode/xnode.o xnode/xnode.c
xnode/xnode.c: In function ‘xnode_first_child_tag’:
xnode/xnode.c:37: warning: value computed is not used
|
Thu 11 Nov 2010 02:41:14 AM UTC, comment #3:
http://git.savannah.gnu.org/cgit/elim.git/log/?h=garbage-filter
|
Mon 08 Nov 2010 05:42:56 PM UTC, comment #2:
Well… it's not at the top of my list or anything, but
I'll have another look and see if there are any easy
wins I hadn't thought of before.
|
Mon 08 Nov 2010 03:54:27 PM UTC, comment #1:
I thought you were going to give up on this one :)
|
Tue 19 Oct 2010 02:40:34 PM UTC, original submission:
mstevens@mstevens-desktop:~/elim % ./elim-client </dev/urandom
zsh: segmentation fault (core dumped) ./elim-client < /dev/urandom
Core was generated by `./elim-client'.
Program terminated with signal 11, Segmentation fault.
#0 0x0804e1cd in xnode_first_child_tag ()
(gdb) bt
#0 0x0804e1cd in xnode_first_child_tag ()
#1 0x0804d5cf in sexp_handler ()
#2 0x0024ce5b in ?? () from /lib/libglib-2.0.so.0
#3 0x00205855 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#4 0x00209668 in ?? () from /lib/libglib-2.0.so.0
#5 0x00209ba7 in g_main_loop_run () from /lib/libglib-2.0.so.0
#6 0x0804d965 in main ()
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
Follow 4 latest changes.