bugRAPP - Raster Processing Primitives - Bugs: bug #31888, Test suite fails on mac osx

 
 

bug #31888: Test suite fails on mac osx

Submitted by:  Johan Almbladh <johanalmbladh>
Submitted on:  Wed 15 Dec 2010 10:21:41 AM UTC  
 
Category: NoneSeverity: 5 - Blocker
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Hans-Peter Nilsson <hpataxis>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Feb 2011 09:00:21 AM UTC, comment #4:

Fix committed, update your git tree or wait for the next release.

Hans-Peter Nilsson <hpataxis>
Project AdministratorIn charge of this item.
Sat 19 Feb 2011 08:35:31 AM UTC, comment #3:

My bad, I missed that rapp_bitblt_copy was called from the test harness for rapp_morph_bin...

So, there are "only" two overlap bugs here, with fixes to be pushed shortly.

Hans-Peter Nilsson <hpataxis>
Project AdministratorIn charge of this item.
Fri 18 Feb 2011 07:42:36 AM UTC, comment #2:

There seems to be more than one bug here.

I'll take back comment #1: that's not the correct formula. At a second look, the checks actually seem to be correct except that dst, src, src_off, dst_off have to be "realigned" as is done in the driver after the call: remember that data "outside" the source image can be read. As it's stored as-is (if the offset difference is 0), overwriting the previous dst data, that counts as overlap. That might be the core bug, though.

The errors in rapp_morph_bin_rect can't be secondary from any overlap checks, as rapp_bitblt_copy_bin isn't called, but instead the (non-checking) rc_* functions. I'm suspecting a bug in the core code. Can you please look into that one?

The rapp_reduce error might very well be a third error; another overlap-checking-error, or a core code bug in compute/vector/rc_reduce.c:rc_reduce_2x2_u8.

I'm assigning this bug to me, but can you please look into at least the rapp_morph_bin_rect error?

Hans-Peter Nilsson <hpataxis>
Project AdministratorIn charge of this item.
Wed 15 Dec 2010 11:09:57 PM UTC, comment #1:

That certainly sounds like the correct formula. Regarding the test-suite, unfortunately the overlap checks lack in testing for spurious overlap detection, which could be improved a little (at least to cover this bug) by making the dst_buf and src_buf use the same rapp_malloc.

Hans-Peter Nilsson <hpataxis>
Project AdministratorIn charge of this item.
Wed 15 Dec 2010 10:21:41 AM UTC, original submission:

I get errors when running the test suite. Something is wrong with bitblits. Looking into it, I see that the overlap check triggers, and this causes secondary errors in rapp_morph_bin_rect. I think that the overlap check in rapp_bitblt_driver() is wrong. Beware of that the src pointer is not necessarily aligned here, so aligning the width from there would be incorrect. Shouldn't the src buffer size be src_dim * (height - 1) + (width + src_off + 7) / 8?

rapp_bitblt_xor_bin
Got FAIL return value
FAILED: rapp_bitblt_xor_bin
rapp_bitblt_nand_bin
Got FAIL return value

rapp_reduce - 8-bit 2x reduction
rapp_reduce_1x2_u8
rapp_reduce_2x1_u8
Got FAIL return value
FAILED: rapp_reduce_2x1_u8
rapp_reduce_2x2_u8

rapp_morph_bin - binary morphology
rapp_morph_erode_rect_bin
Invalid result
dst=
..................11111111111111111
ref=
11111111111111111111111111111111111
FAILED: rapp_morph_erode_rect_bin
rapp_morph_dilate_rect_bin
Invalid result
dst=
111111111111111111.................
ref=
...................................
FAILED: rapp_morph_dilate_rect_bin

Best regards
/Johan

Johan Almbladh <johanalmbladh>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hpataxis (Posted a comment)
  • -unavailable- added by johanalmbladh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Feb 2011 09:00:21 AM UTChpataxisStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 18 Feb 2011 07:42:36 AM UTChpataxisAssigned toNone=>hpataxis
    Wed 16 Feb 2011 12:32:11 AM UTChpataxisSeverity4 - Important=>5 - Blocker
      StatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1