bugAVR C Runtime Library - Bugs: bug #31990, PRPSC0 used in power.h for...

 
 

bug #31990: PRPSC0 used in power.h for AT90PWM81 instead of PRPSCR

Submitted by:  Praveen Kaushik <praveenkaushik>
Submitted on:  Mon 27 Dec 2010 10:21:08 AM UTC  
 
Category: HeaderSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Header files
Status: FixedPercent Complete: 100%
Assigned to: Anitha Boyapati <aboyapati>Open/Closed: Closed
Release: 1.7.0Fixed Release: 1.6.1

Discussion locked!

 

Fri 11 Feb 2011 06:55:41 AM UTC, comment #2:

Patch looks fine. Preparing to commit.

Anitha Boyapati <aboyapati>In charge of this item.
Mon 27 Dec 2010 10:36:01 AM UTC, comment #1:

Hi,
Please review the patch for this bug.
I have changed:
<avr-libc>/include/avr/io90pwm81.h-PRPSC0 changed to PRPSCR
<avr-libc>/include/avr/power.h-Changed PRPSC0 to PRPSCR in #elif defined(_AVR_AT90PWM81_) section, documentation updated.

(file #22297)

Praveen Kaushik <praveenkaushik>
Mon 27 Dec 2010 10:21:08 AM UTC, original submission:

power.h uses the macro PRPSC0 for AT90PWM81

#elif defined(_AVR_AT90PWM81_)
...
/* Power Stage Controller 0 */
#define power_psc0_enable() (PRR &= (uint8_t)~(1 << PRPSC0))
#define power_psc0_disable() (PRR |= (uint8_t)(1 << PRPSC0))
...
...
define power_all_enable() (PRR &= (uint8_t)~((1<<PRADC)|(1<<PRSPI)|(1<<PRTIM1)|(1<<PRPSC0)|(1<<PRPSC2)))
#define power_all_disable() (PRR |= (uint8_t)((1<<PRADC)|(1<<PRSPI)|(1<<PRTIM1)|(1<<PRPSC0)|(1<<PRPSC2)))
...

but the XML file shipped with AVR Studio 4, specifies it as PRPSCR.

Praveen Kaushik <praveenkaushik>

 

Attached Files
file #22650:  bug31990.patch added by aboyapati (11KiB - text/x-patch - Final patch with Changelog and NEWS updated)
file #22297:  patch added by praveenkaushik (10KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by aboyapati (Posted a comment)
  • -unavailable- added by praveenkaushik (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Feb 2011 11:38:13 AM UTCaboyapatiStatusNone=>Fixed
      Discussion LockUnlocked=>Locked
      Fixed ReleaseNone=>1.6.1
    Fri 11 Feb 2011 11:32:38 AM UTCaboyapatiPercent Complete0%=>100%
      Assigned toNone=>aboyapati
      Open/ClosedOpen=>Closed
    Fri 11 Feb 2011 06:58:47 AM UTCaboyapatiAttached File-=>Added bug31990.patch, #22650
    Mon 27 Dec 2010 10:36:01 AM UTCpraveenkaushikAttached File-=>Added patch, #22297

    Back to the top


    Powered by Savane 3.1-cleanup1