bugSystem V style init programs - Bugs: bug #32304, Patches for sulogin

 
 

bug #32304: Patches for sulogin

Submitted by:  Florent Viard <fviard>
Submitted on:  Mon 31 Jan 2011 02:01:19 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Dr. Werner Fink <wfink>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 30 Mar 2011 05:02:46 PM UTC, comment #3:

I've not added this patch has I'm working on sulogin
to support more than one physical device connected
to /dev/console ... currently I've a working version.
It now supports also serial lines as well as virtual
consoles.

Remaining problems are something like locking e.g.
with mmap to avoid that on performed sulogin can
be killed on the other line and also one should
test out if the stuff compiles with freeBSD setup
on Debian.

See attachment

Werner

(file #23060)

Dr. Werner Fink <wfink>
Project AdministratorIn charge of this item.
Mon 21 Mar 2011 02:11:30 PM UTC, comment #2:

Hi
Thank you.

but, don't you want to also apply the following patch?
03_sulogin-3.patch (diff format):
Changes the getpasswd function to be able to also support the case of term sending the input only character by character (only one at a time)

Because it is a real issue. When we are in that case, only one character of the user input is compared to the password, and so the test will fail, and the user will be stuck not being able to login.

Florent Viard <fviard>
Fri 11 Mar 2011 03:55:34 PM UTC, comment #1:

Add changes accordingly to your patches.
Please remember useing exit(3) or stdio(3)
within a signal handler is a bad idea.

Dr. Werner Fink <wfink>
Project AdministratorIn charge of this item.
Mon 31 Jan 2011 02:01:19 PM UTC, original submission:

Hi,

here are some patches for sulogin.

01_sulogin-1.svnpatch (svn format):
Fixes signal handler saving errors.

02_sulogin-2.patch (diff format):
Fixes code to support the "-t" option (ie: timeout)

03_sulogin-3.patch (diff format):
Changes the getpasswd function to be able to also support the case of term sending the input only character by character (only one at a time)

Florent Viard <fviard>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22571:  02_sulogin-2.patch added by fviard (902B - text/x-patch)
file #22572:  03_sulogin-3.patch added by fviard (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fviard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 30 Mar 2011 05:02:46 PM UTCwfinkAttached File-=>Added sysvinit-2.88dsf-multiple-sulogin.patch, #23060
    Fri 11 Mar 2011 04:17:34 PM UTCwfinkAssigned toNone=>wfink
      Open/ClosedOpen=>Closed
    Fri 11 Mar 2011 03:55:34 PM UTCwfinkStatusNone=>Fixed
    Mon 31 Jan 2011 02:01:19 PM UTCfviardAttached File-=>Added 01_sulogin-1.svnpatch, #22570
      Attached File-=>Added 02_sulogin-2.patch, #22571
      Attached File-=>Added 03_sulogin-3.patch, #22572

    Back to the top


    Powered by Savane 3.1-cleanup1