Mon 25 Jul 2011 08:28:32 AM UTC, comment #4:
Confirmed that this is not related to #33235 .
Also confirmed that this is specific to the trust plugin.
937:46ea253a48fb helps illustrate this
http://hg.savannah.gnu.org/hgweb/bokeep/rev/46ea253a48fb
as we now do a frontend detach prior to the plugin config dialog, so as soon as that dialog pops up you can see if it worked. This made it very easy to confirm that the mileage and payroll plugins were not having the same problem.
One obvervation I made while trying to track this down is that the top level widget for the trust gui is a gtk.Table, and I tried embedding that in a vbox as a new top level widges like the other plugins used and it didn't help.
Also, the issue that was resolved in #33235 (which was a problem for every plugin) isn't assymetric, like this one -- you can switch from the trust plugin to a book with no transactions and the trust plugin gui disappears properly just like all the others.
As for what Jamie last said, it is the case that the api is standardized across plugins here, the editor.detach method, and how it should behave is mandatory. And what we know from the above is that the detach method does work correctly in at least one circumstance... so its a mystery why it doesn't work in the plugin config dialog event handler.
Seeing how I've defended my core now, I'm re-assigning to Samuel.
Not a clue why detach() doesn't work in all circumstances, but I do know that one difference between the trust plugin and others is that it uses a more ancient way of loading up a glade file and getting access to the widgets compared to the other plugins.
Making the trust plugin more uniform in how it uses glade would probably be a valuable thing in itself -- and even nicer if doing so also inadvertently solves the bug for us...
|