bugBo-Keep - Bugs: bug #32815, trust plugin doesn't detach during...

 
 

bug #32815: trust plugin doesn't detach during plugin config process

Submitted by:  Mark Jenkins <markjenkins>
Submitted on:  Wed 16 Mar 2011 09:08:25 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: -Deleted Account- <samuelpauls>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 26 Jul 2011 03:10:54 AM UTC, comment #6:

Problem turned out to be caused by the fact that the trust plugin's config wasn't a dialog and as such didn't block the reattachment of the trust transaction editor. Therefore reattachment happened immediately after detatchment, but before the config could be changed!

-Deleted Account- <samuelpauls>In charge of this item.
Tue 26 Jul 2011 02:13:57 AM UTC, comment #5:

Seems that the trust plugin actually does detatch during config, but the problem is actually that it reattaches right away. Other plugins reattach after their config is done.

-Deleted Account- <samuelpauls>In charge of this item.
Mon 25 Jul 2011 08:28:32 AM UTC, comment #4:

Confirmed that this is not related to #33235 .

Also confirmed that this is specific to the trust plugin.
937:46ea253a48fb helps illustrate this
http://hg.savannah.gnu.org/hgweb/bokeep/rev/46ea253a48fb
as we now do a frontend detach prior to the plugin config dialog, so as soon as that dialog pops up you can see if it worked. This made it very easy to confirm that the mileage and payroll plugins were not having the same problem.

One obvervation I made while trying to track this down is that the top level widget for the trust gui is a gtk.Table, and I tried embedding that in a vbox as a new top level widges like the other plugins used and it didn't help.

Also, the issue that was resolved in #33235 (which was a problem for every plugin) isn't assymetric, like this one -- you can switch from the trust plugin to a book with no transactions and the trust plugin gui disappears properly just like all the others.

As for what Jamie last said, it is the case that the api is standardized across plugins here, the editor.detach method, and how it should behave is mandatory. And what we know from the above is that the detach method does work correctly in at least one circumstance... so its a mystery why it doesn't work in the plugin config dialog event handler.

Seeing how I've defended my core now, I'm re-assigning to Samuel.

Not a clue why detach() doesn't work in all circumstances, but I do know that one difference between the trust plugin and others is that it uses a more ancient way of loading up a glade file and getting access to the widgets compared to the other plugins.

Making the trust plugin more uniform in how it uses glade would probably be a valuable thing in itself -- and even nicer if doing so also inadvertently solves the bug for us...

Mark Jenkins <markjenkins>
Project Administrator
Mon 09 May 2011 09:00:20 PM UTC, comment #3:

I'll takeover this bug.

Mark Jenkins <markjenkins>
Project Administrator
Thu 05 May 2011 08:04:13 PM UTC, comment #2:

I'm diverted to other items, I'd be ok with someone else finishing this off.

From what I can tell so far, no plugins do a reload after config. Rather than having a trust-specific fix the way I'd do it would be to have the framework do a refresh on the current editor after config is done. In the same way all plugins have to provide some sort of editor, they'd also be expected to provide a refresh method. If they don't, it would see there's no such method and do nothing, but either way, would be a standardized approach rather than treating all the plugins differently.

Jamie <paritjamie>
Project Administrator
Thu 05 May 2011 12:59:13 AM UTC, comment #1:

May be related to or even the same bug as #33235 -- won't be clear until they're dug into . Wondering where we're at on this one.

Mark Jenkins <markjenkins>
Project Administrator
Wed 16 Mar 2011 09:08:25 PM UTC, original submission:

The trust plugin doesn't reload interface right after doing config on it, tested in the num trustors 0 case, new trustors don't show up

Mark Jenkins <markjenkins>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by samuelpauls (Posted a comment)
  • -unavailable- added by paritjamie (Posted a comment)
  • -unavailable- added by markjenkins (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Jul 2011 03:10:54 AM UTCsamuelpaulsStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Mon 25 Jul 2011 08:28:32 AM UTCmarkjenkinsStatusNone=>Confirmed
      Assigned tomarkjenkins=>samuelpauls
      Summarytrust plugin doesn\'t reload interface right after config=>trust plugin doesn't detach during plugin config process
    Mon 09 May 2011 09:00:20 PM UTCmarkjenkinsAssigned toparitjamie=>markjenkins
    Fri 15 Apr 2011 04:36:35 PM UTCmarkjenkinsAssigned tomarkjenkins=>paritjamie

    Back to the top


    Powered by Savane 3.1-cleanup1