bugLordsAWar! - Bugs: bug #32817, create-lw-file patch from FreeBSD...

 
 

bug #32817: create-lw-file patch from FreeBSD ports

Submitted by:  Dmitrij D. Czarkoff <czarkoff>
Submitted on:  Wed 16 Mar 2011 11:36:20 PM UTC  
 
Category: building/compilationSeverity: 3 - Normal
Item Group: Git HeadStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 19 Mar 2011 06:14:42 PM UTC, comment #7:

I am definitely concerned with increasing the popularity of LordsAWar! I disagree that your patch would affect the popularity of this project.

Ben Asselstine <benasselstine>
Project Administrator
Sat 19 Mar 2011 05:51:00 PM UTC, comment #6:

It causes me nothing, it just hurts YOURS project's popularity with NO tradeoff. I just want to help the project.

Dmitrij D. Czarkoff <czarkoff>
Sat 19 Mar 2011 05:15:14 PM UTC, comment #5:

They are "big fat dependencies" on your system, not mine. I think if you take some time to reflect, you will realize that I am not writing this game on a BSD or specifically for the BSDs.

My target platform is GNU+Linux.

If the small number of changes that are required to make LordsAWar! compile and run on your operating system overloads you (or anybody else), then perhaps packaging upstream software isn't a task you are suited for.

The Debian project will probably change the bash shell to the dash shell, and the Fedora project just today submitted a patch to include offline support for reading the manual.

I realize you do not agree with my rationale for not accepting your patch to the file in question. I sincerely hope it doesn't cause you too much extra work.

Ben Asselstine <benasselstine>
Project Administrator
Sat 19 Mar 2011 03:14:40 PM UTC, comment #4:

You happen to be missing a big fat point of mine: Your package has two additional dependencies that are abolutely not needed, that will be surely patched thus loading maintainer with unneeded work of updating patch at random times.

This all is done because (1) You personally like bash (which has nothing to deal with LordsAWar!) and (2) You prefer GNUish long options to short ones explained in comments.

Yes, GNU coreutils are preloaded with BSDs, but they are stripped from mktemp, which isn't in packages and isn't going to ever land there, because GNU's mktemp isn't anyhow better then BSD's traditional one.

So, You jut overload maintainers to what?

Dmitrij D. Czarkoff <czarkoff>
Sat 19 Mar 2011 03:05:55 PM UTC, comment #3:

This script conforms to shell syntax afaict.

The GNU project takes special effort in adding these long options to standard POSIX programs for good reasons: 1. they makes shell scripts like these easier to read. 2. They also make the options easier to remember. The trade-off is portability which I am happy to make since the GNU coreutils are almost everywhere anyway

I realize that this isn't helpful to the BSDs, but as you can see from the patch, it is very simple to revert the trade-off I have made if it doesn't suit their system.

Ben Asselstine <benasselstine>
Project Administrator
Sat 19 Mar 2011 12:25:26 PM UTC, comment #2:

OK, leave bash alone. (Still can't get the reason for bash'ing script that conforms to sh syntax.)

The BSD verions of mktemp only supports short options. GNU coreutils' mktemp supports both. May be this part of a patch deserves inclusion?

Dmitrij D. Czarkoff <czarkoff>
Thu 17 Mar 2011 12:39:58 AM UTC, comment #1:

I like the dependency on bash; I think it should be installed in more places... especially on the BSDs.

I suggest you exercise your freedom to work around my choice of bash as the shell for create-lw-file.

Ben Asselstine <benasselstine>
Project Administrator
Wed 16 Mar 2011 11:36:20 PM UTC, original submission:

Please consider including changes from the FreeBSD ports patch (http://www.freebsd.org/cgi/cvsweb.cgi/ports/games/lordsawar/files/patch-create-lw-file) as it (1) removes unneeded dependency on bash (which isn't installed by default in BSDs and several minor linux distros) and (2) changes mktemp arguments to those common for linux and BSD flavours.

It's harmless, but helps on BSDs.

Dmitrij D. Czarkoff <czarkoff>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by benasselstine (Posted a comment)
  • -unavailable- added by czarkoff (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 17 Mar 2011 12:39:58 AM UTCbenasselstineOpen/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1