bugBino - Bugs: bug #33351, LIRC: dont't work correctly on...

 
 

bug #33351: LIRC: dont't work correctly on no-gui mode

Submitted by:  Robert Pliszko <plesken>
Submitted on:  Thu 19 May 2011 03:02:24 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Privacy: PublicAssigned to: Martin Lambers <marlam>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 May 2011 07:05:10 PM UTC, comment #1:

Thanks for diagnosing this. The problem was that we did not announce that the player was now playing:

diff --git a/src/player.cpp b/src/player.cpp
index bb60a2f..bff89a1 100644
--- a/src/player.cpp
+++ b/src/player.cpp
@@ -706,6 +706,7 @@ bool player::run_step()

void player::run()
{
+ controller::notify_all(notification::play, false, true);
while (run_step());
}

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Thu 19 May 2011 03:02:24 PM UTC, original submission:

Describe of problem:

I'm using bino without gui with "-n" option (I run bino via xbmc). I've checked it, I modified lirc.cpp (I'm not programmer on C and C++):

...
else if (t == "play")
{
if (!_playing)
{
msg::wrn(_("Start playing...));
c = command(command::toggle_play);
}
else if (_pausing)
{
msg::wrn(_("Pause..."));
c = command(command::toggle_pause);
}
else
{
msg::wrn(_("Do nothing..."));
c = command(command::noop);
}
}
...

As you see I added msg:wrn(...). So, If I run bino with gui:

[plesken@localhost ~]$ bino
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xa9740d0] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] Start playing..., _playing =
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xafa9300] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] Do nothing...
bino: [wrn] Stop...
bino: [wrn] Start playing...
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xa964f20] Estimating duration from bitrate, this may be inaccurate
bino: [wrn] Do nothing...
bino: [wrn] Pause...
bino: [wrn] Pause...
bino: [wrn] Video: późnienie 1,61423 sekund; odrzucanie następnej ramki.
bino: [wrn] Video: późnienie 1,57323 sekund; odrzucanie następnej ramki.
bino: [wrn] Video: późnienie 1,53123 sekund; odrzucanie następnej ramki.
bino: [wrn] Pause...
bino: [wrn] Pause...
bino: [wrn] Stop...

It's working perfectly! BUT! If I run bino without gui:

[plesken@localhost ~]$ bino --input=separate-left-right /home/plesken/Wideo/3D/Clash\ Of\ The\ Titans/Clash.Of.The.Titans.3DBD.LEFT.1080p.D.D.5.1.x264-SWEMUX.mkv /home/plesken/Wideo/3D/Clash\ Of\ The\ Titans/Clash.Of.The.Titans.3DBD.RIGHT.1080p.D.D.5.1.x264-SWEMUX.mkv --output=red-cyan-dubois --audio=1 --subtitle=1 -n --lirc-config=/home/plesken/.lircrc
bino: [wrn] FFmpeg: [matroska,webm @ 0x997cb90] Estimating duration from bitrate, this may be inaccurate
bino: [inf] /home/plesken/Wideo/3D/Clash Of The Titans/Clash.Of.The.Titans.3DBD.LEFT.1080p.D.D.5.1.x264-SWEMUX.mkv:
bino: [inf] Strumień video 0: 1920x1080, 1,78:1 / 1920x1080-1,78:1-yuv420p-601-mpeg-l, 6367,58 sekund
bino: [inf] Użyj do 2 wątków do dekodowania.
bino: [inf] Strumień audio 0: nieznany, 6 ch., 48 kHz, 16 bit / nieznany-6-48000-s16, 6367,58 sekund
bino: [wrn] FFmpeg: [matroska,webm @ 0x99fabe0] Estimating duration from bitrate, this may be inaccurate
bino: [inf] /home/plesken/Wideo/3D/Clash Of The Titans/Clash.Of.The.Titans.3DBD.RIGHT.1080p.D.D.5.1.x264-SWEMUX.mkv:
bino: [inf] Strumień video 0: 1920x1080, 1,78:1 / 1920x1080-1,78:1-yuv420p-601-mpeg-l, 6367,36 sekund
bino: [inf] Użyj do 2 wątków do dekodowania.
bino: [inf] Wejście:
bino: [inf] Video #1/2: 1920x1080, 1,78:1: 1920x1080-1,78:1-yuv420p-601-mpeg-l
bino: [inf] Video #2/2: 1920x1080, 1,78:1: 1920x1080-1,78:1-yuv420p-601-mpeg-l
bino: [inf] Audio nieznany, 6 ch., 48 kHz, 16 bit: nieznany-6-48000-s16
bino: [inf] Brak napisów.
bino: [inf] Czas trwania: 6367,36 sekund
bino: [inf] Układ stereo: separate-left-right
bino: [wrn] Video: późnienie 0,037791 sekund; odrzucanie następnej ramki.
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Start playing...
[plesken@localhost ~]$

You see the warn message is "Do nothing..." - I clicked on "pause", "stop" few times. When I clicked on "play" the bino closed down and warn was "Start playing...". I've noticed the problem is on "_playing" variable on the lirc.cpp which is not set.

...
else if (t == "play")
{
if (!_playing) {
^^^^^^^^^^^^^^^^^^^^
...

If we run bino with gui the variable _playing automaticaly set on "false", and when we push button play this variable change to "true" and rest of them work correctly.

If we run bino without gui the variable is set on "false", but movie is playing, so we can't use "pause" and "stop", before click on remote control "play" first. OK, we are clicking on play button. The variable "_playing" still has not changed on "true", so if code is:

...
if (!_playing)
{
msg::wrn(_("Start playing...));
c = command(command::toggle_play);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
}
else if (_pausing)
{
msg::wrn(_("Pause..."));
c = command(command::toggle_pause);
}
else
{
msg::wrn(_("Do nothing..."));
c = command(command::noop);
}
...

We run "toggle-play" which stopped play bino without gui.
So if I can programm on C and C++ I will fix it, but I don't.

Robert Pliszko <plesken>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by marlam (Posted a comment)
  • -unavailable- added by plesken (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 May 2011 07:05:10 PM UTCmarlamStatusNone=>Fixed
      Assigned toNone=>marlam
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1