bugBino - Bugs: bug #33366, Add support for the MPO file format

 
 

bug #33366: Add support for the MPO file format

Submitted by:  Martin Lambers <marlam>
Submitted on:  Sun 22 May 2011 08:46:52 AM UTC  
 
Severity: 1 - WishStatus: None
Privacy: PublicAssigned to: Martin Lambers <marlam>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 28 Jan 2012 10:00:42 AM UTC, comment #7:

Hi, I added a patch based on this discussion:

http://git.savannah.gnu.org/cgit/bino.git/commit/?id=6496c90cbbbde5560aa7b147557ca469055777e1

This first patch only adds support for the alternating stereo layout, which is now automatically selected for MPO files. Some things in this patch are a little different from what you proposed.

For now, I left out the code that handles files in a directory (skipping, autostarting etc). This should probably be handled in a separate approach to add full playlist support, including image playlists.

If you would like changes, please let me know. For now, I added 'D. Matz' to the AUTHORS file and to copyright notices; do you prefer a different entry?

Thanks for your contributions!
Martin

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Tue 10 Jan 2012 09:05:35 AM UTC, comment #6:

Sorry my change submit was without any comments so here they come:

I added support for MPO based on version 1.2.1 (deployed). A new stereo_layout 'alternating' is used once a file with MPO extension is detected. The image then is displayed immediately, without the need to hit play, for convenience. Seek buttons now work to jump back/forward through the file list in the current directory (also for convenience). Seeking video is not affected by this logic.
There are 3 points I'm not happy with right now.
1) I needed an extra AVFrame to cache the left view. The decoder buffer is reused for the right (2nd) frame and overwrites the left one. I tried to use separate AVFrames to call avcodec_decode_video2() but without success because the data buffer itself will be the same.
2) For now to step to next/prev image or video there is no filtering of file types in the current file list. I have to improve that, checking for file extensions which can handled by the player.
3) The detection if the player should seek in a video or step to next media is not based on a file type, I just check for the video duration which is constant for still images. This is a little bit weak, there is a TODO item inside the code.

Hope that you guys are fine with these changes. Please give me feedback whether it's ready for integration or needs some fixes first.

D. Matz <matzkowsky>
Thu 17 Nov 2011 06:14:47 AM UTC, comment #5:

FFmpeg now has support for MPO files (that was fast!); see their commit 1d23e5246c67f765dd5d119c9f3197bdae07330c.

It treats MPO as a two-frame video: first frame is the left image, second frame is the right image.

That means we need to add a new stereo_layout type 'alternating' (or similar) that tells Bino to read left and right views from two consecutive frames. Only the code in media_object needs to be changed; everything else can probably work as is because 'alternating' would be equivalent to 'separate' once both views are read.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Wed 16 Nov 2011 08:54:43 PM UTC, comment #4:

I uploaded a sample to upload.ffmpeg.org; see <http://ffmpeg.org/pipermail/ffmpeg-devel/2011-November/116894.html>.

If anyone else is interested in this file, please let me know.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.
Wed 16 Nov 2011 12:13:18 PM UTC, comment #3:

please upload an mpo file so ffmpeg can look at it.

Anonymous
Fri 02 Sep 2011 08:27:54 PM UTC, comment #2:

Hi, i would try to but it into bino...
i'll need some time to read the <a href="http://www.cipa.jp/english/hyoujunka/kikaku/pdf/DC-007_E.pdf">Definition</a> and to implent it (i'm familiar to C#, and learned C(++), so i gonna need some time) hope i will find a solution
Henry

Henrik R. <henrytm>
Fri 02 Sep 2011 07:54:33 PM UTC, comment #1:

i would try it

Anonymous
Sun 22 May 2011 08:46:52 AM UTC, original submission:

This format can contain multiple JPEG images and is used by the Fujifilm FinePix Real 3D camera (and others) to store the left and right view of a stereoscopic photo.

Supporting this format would allow users to directly view their stereoscopic photos with Bino.

This requires writing a demuxer for FFmpeg that makes the JPEG images available in separate streams.

Martin Lambers <marlam>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24793:  diff-120109 added by matzkowsky (43KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by matzkowsky (Updated the item)
  • -unavailable- added by henrytm (Posted a comment)
  • -unavailable- added by marlam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 28 Jan 2012 10:00:42 AM UTCmarlamAssigned toNone=>marlam
      Open/ClosedOpen=>Closed
    Tue 10 Jan 2012 08:45:28 AM UTCmatzkowskyAttached File-=>Added diff-120109, #24793

    Back to the top


    Powered by Savane 3.1-cleanup1