bugmldonkey, a multi-networks file-sharing client - Bugs: bug #3338, Check file MD4 before commit

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #3338: Check file MD4 before commit

Submitted by:  Markus Hitter <hitterm>
Submitted on:  Sat 26 Apr 2003 07:47:50 PM UTC  
 
Category: CoreSeverity: 1 - Wish
Item Group: Feature requestStatus: Wont Fix
Assigned to: NoneOpen/Closed: Closed
Release: 2.04rc3Release: 2-5-12
Operating System: Mac OS X 10.3Binaries Origin: CVS / Self compiled
CPU type: None

Mon 03 May 2004 01:13:01 PM UTC, comment #4:

Use the ed2k_hash utility (compile it in mldonkey using 'make utils') instead of md4sum, since the ed2k hashes ARE NOT md4s, they are MD4 of the sum of the MD4s of all chunks (except if there is only one chunk, which explains why this bug appears only with big files...).

Anonymous
Mon 08 Mar 2004 04:52:05 PM UTC, comment #3:

I think i've the same problem, the md4 of many files i've downloaded differs from the entry in the files.ini.
It occured with every release up to 2.5.16, reproducable (so
nearly every "big" download has this problem, perhaps it's cause
i've to stop and restart the mldonkey a couple of times every day)

Quorrl <Quorrl>
Wed 25 Feb 2004 10:20:08 AM UTC, comment #2:

This happened right last week with fresh CVS sources again.

The bug is easy to reproduce: stop mlnet, edit files.ini and set one of the chunks from status 0 (empty) or 1 (partial) to 2 (finished). Then wait until this file is finished. The file will be commited without further testing, spreading bad chunks into the world.

Since downloads tend to be the result of a lot of small parts and the download algorithm is quite complex and mlnet has to wrestle with disk full conditions quite often and even some users try to massage partial downloads manually, an additional check whould me more than welcome. Azureus offers this an an option, for example.

Markus Hitter <hitterm>
Wed 25 Feb 2004 01:16:11 AM UTC, comment #1:

Please check if this bug still is in current CVS version.
You should a tarball of current CVS in files section of
this project: http://savannah.nongnu.org/download/mldonkey/

spiralvoice <spiralvoice>
Project Administrator
Sat 26 Apr 2003 07:47:50 PM UTC, original submission:

Today a download ended with a bad file:

Nobile:~/MLdonkey2.04rc3/temp$ ../../md4sum-0.01.03/md4sum C35D85963FD1448992877AECB4BD847E
3de5d87577920b09892c8e8109edc822
(md4 and filename differ)

The file was marked for commit. This shouldn't happen. Instead, the md4 should be calculated again to assure the download is fine. Just, to reassure the code is actually working. Remember, this bad file can be available for sharing without the knowledge of the user.

Markus Hitter <hitterm>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 10 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 10 Aug 2004 10:38:41 AM UTCspiralvoiceOpen/ClosedOpen=>Closed
Tue 10 Aug 2004 08:07:22 AM UTCmldonkeySeverity6 - Security=>1 - Wish
  StatusNone=>Wont Fix
Mon 08 Mar 2004 04:52:05 PM UTCQuorrlCarbon-Copy-=>Added quorrl
Sun 07 Mar 2004 05:04:31 PM UTCt8mCarbon-Copy-=>Added t8m
Tue 02 Mar 2004 08:46:52 PM UTCspiralvoiceSeverity4 - Important=>6 - Security
  Item GroupNone=>Feature request
  Release2.00=>2-5-12
  SummaryBad download was marked for commit=>Check file MD4 before commit
Wed 25 Feb 2004 01:16:11 AM UTCspiralvoiceSeverity3 - Normal=>4 - Important

Back to the top


Powered by Savane 3.1-cleanup1