buglwIP - A Lightweight TCP/IP stack - Bugs: bug #33561, bugs in recvfrom() and sendto()

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33561: bugs in recvfrom() and sendto()

Submitted by:  hanhui <hanhui03>
Submitted on:  Tue 14 Jun 2011 05:45:06 AM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

(Jump to the original submission Jump to the original submission)

Wed 06 Jul 2011 07:22:39 AM UTC, comment #6:

Yep, missed that, sorry. I'm still working on getting a good testbench running to prevent such (newly introduced) bugs. I've (hopefully) fixed it again, although I cannot test it right now :-(

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 06 Jul 2011 01:52:54 AM UTC, comment #5:

No no no.

you modify the SOCKADDR4_TO_IP4ADDR_PORT(), this is correct! but lwip_bind() and lwip_connect() also must modify the parameter of netconn_bind() and netconn_connect(), because "port" is already LOCAL BYTE ORDER!

Thanks!

hanhui <hanhui03>
Tue 05 Jul 2011 07:45:45 PM UTC, comment #4:

Fixed, thanks for reporting!

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 04 Jul 2011 07:42:26 PM UTC, comment #3:

Fixed comment #2, need more time to check the bugs reported in the original post.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 23 Jun 2011 09:17:02 AM UTC, comment #2:

and:

int
lwip_sendto(...)
{
if (!SOCK_ADDR_TYPE_MATCH(to, sock)) {
...
}
}

should be:

int
lwip_sendto(...)
{
if (to && !SOCK_ADDR_TYPE_MATCH(to, sock)) {
...
}
}

hanhui <hanhui03>
Wed 15 Jun 2011 03:55:28 PM UTC, comment #1:

I confirm that these are bug!

hanhui <hanhui03>
Tue 14 Jun 2011 05:45:06 AM UTC, original submission:

1: recvfrom()

recvfrom dos not copy remote address and remote port to parameter "from" and "fromlen"

2: sendto()

in CORE_LOCKING mode, udp_sendto_...() parameter "remote_port"

should be "LOCAL BYTE ORDER".

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 Jul 2011 07:45:53 PM UTCgoldsimonOpen/ClosedOpen=>Closed
    Tue 05 Jul 2011 07:45:45 PM UTCgoldsimonStatusIn Progress=>Fixed
    Mon 04 Jul 2011 07:42:26 PM UTCgoldsimonStatusNone=>In Progress
      Assigned toNone=>goldsimon

    Back to the top


    Powered by Savane 3.1-cleanup1