bugIdentica mode - Bugs: bug #33728, requiring oauth.el even for non...

 
 

bug #33728: requiring oauth.el even for non oauth users cause problems

Submitted by:  Gabriel Saldana <gabrielsaldana>
Submitted on:  Fri 08 Jul 2011 07:09:45 AM UTC  
 
Category: BugSeverity: 5 - Blocker
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Kevin Granade <kevingranade>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 07 Sep 2011 06:18:12 PM UTC, comment #3:

Additional to Kevin Granade's patch, I've added autoload calls to identica-mode startup so it is not needed to add (require 'oauth) in anticipation.

I had oauth configured but no (require 'oauth) set on my init file, so whenever I wanted to post, it gave me an error on any oauth.el related functions. The autoloads will do that for you whenever "oauth" is set as the authentication method.

Gabriel Saldana <gabrielsaldana>
Project Administrator
Sat 13 Aug 2011 10:09:02 PM UTC, comment #2:

Just pushed commit that addresses this, please let me know if it causes any problems.
http://git.savannah.gnu.org/cgit/identica-mode.git/commit/?h=devel&id=2cd764e51d9748e2562b4478a92e3232d2423754

Kevin Granade <kevingranade>
Project MemberIn charge of this item.
Thu 14 Jul 2011 03:20:01 PM UTC, comment #1:

My apologies for my elisp noob-ishness. I believe changing:
(require 'oauth)
to:
(require 'oauth nil t)

Will suppress the error and allow identica-mode to load regardless of the presence of the oath module. Of course it will then explode if it tries to call any of the oauth methods. I'll ponder the best way to handle this moving forward.

Kevin Granade <kevingranade>
Project MemberIn charge of this item.
Fri 08 Jul 2011 07:09:45 AM UTC, original submission:

@aidalgol reported:
(file-error "Cannot open load file" "oauth") I get this loading !identicamode with the latest commit. (I don't use OAuth)

Some users do not wish to use or install the oauth library, and requiring it regardless prevents the mode from loading. There should be a way to require it only if identica-set-auth is "oauth"

Gabriel Saldana <gabrielsaldana>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kevingranade (Posted a comment)
  • -unavailable- added by gabrielsaldana (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 07 Sep 2011 06:24:37 PM UTCgabrielsaldanaOpen/ClosedOpen=>Closed
    Wed 07 Sep 2011 06:18:38 PM UTCgabrielsaldanaStatusReady For Test=>Fixed
    Sat 13 Aug 2011 10:09:02 PM UTCkevingranadeStatusNone=>Ready For Test
      Assigned toNone=>kevingranade

    Back to the top


    Powered by Savane 3.1-cleanup1