bugPingus - Bugs: bug #33744, SVN source won't build

 
 

bug #33744: SVN source won't build

Submitted by:  Anders Skogheim Liane <maneatingduck>
Submitted on:  Sun 10 Jul 2011 07:09:01 PM UTC  
 
Category: General StuffSeverity: 3 - Normal
Item Group: Installation ProblemStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: SVN
Operating System: LinuxPlanned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 16 Jul 2011 04:32:50 PM UTC, comment #2:

just for further info this confirms what maneatingduck found!

1) you do need to mkdir or the build fails

2) you have to do scons src then scons

3) the files in src/engine/system/ are never compiled as maneatingduck added the single file "sdl_system.cpp" but i have added the following line to SconScript line 239 so all cpp files in there get compiled

Glob('src/engine/system/*.cpp') + \

(there is only one at the moment so it doesnt make any difference but saves problems later if someone adds another .cpp file there!)

Kev

Kevin <colintreebush>
Thu 14 Jul 2011 05:40:00 PM UTC, comment #1:

this patch is great i am a programmer lol) how do we go about getting it added to the main source?

I just made this change myself on my local copy. Who controls access to cvs on this project?

Thanks

Kevin <colintreebush>
Sun 10 Jul 2011 07:09:01 PM UTC, original submission:

When I checked out the source from svn://svn.berlios.de/pingus/trunk/pingus/ the build failed. There were two problems; the build directory would not be created, and src/engine/system/sdl_system.cpp was not compiled, leading to build errors.

I've included a patch which corrects those problems. I added sdl_system.cpp to the optional_sources list, and added mkdir -p build and scons src to Makefile. I also took the liberty of adding the option -j 6 to scons, I don't believe there are good reasons not to use multiple jobs for building? The speedup on a multicore system is significant.

I'm not a programmer by trade, I apologise if my patch is not optimal :)

Anders Skogheim Liane <maneatingduck>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by grumbel (Updated the item)
  • -unavailable- added by colintreebush (Posted a comment)
  • -unavailable- added by maneatingduck (Submitted the item)
  • -unavailable- added by maneatingduck (Så får vi se :))
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Aug 2011 05:25:27 PM UTCgrumbelStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 10 Jul 2011 07:09:01 PM UTCmaneatingduckAttached File-=>Added pingus_build_settings.patch, #23635
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1