buglwIP - A Lightweight TCP/IP stack - Bugs: bug #33804, LWIP_IPV6_MLD #define missing from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33804: LWIP_IPV6_MLD #define missing from mld6.c

Submitted by:  Brad Giffel <bgiffel>
Submitted on:  Tue 19 Jul 2011 08:39:04 PM UTC  
 
Category: IPv6Severity: 3 - Normal
Item Group: Compiler WarningStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Wed 20 Jul 2011 05:01:15 AM UTC, comment #1:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 19 Jul 2011 08:39:04 PM UTC, original submission:

If LWIP_IPV6_MLD is defined as 0 and LWIP_IPV6 is defined as 1, the mld6.c file is compiled when it really shouldn't be. Line 47 of mld6.c should be:

#if LWIP_IPV6_MLD && LWIP_IPV6 /* don't build if not configured for use in lwipopts.h */

Note: technically not a 'Compiler Warning' but more of an actual compilation failure but there was no Item Group for that.

Might suggest that opt.h validate macros like LWIP_IPV6_MLD and force them to zero if LWIP_IPV6 is zero. Then mld6.c can be conditionally compiled by only checking LWIP_IPV6_MLD. Which of course is probably a different ticket....

Brad Giffel <bgiffel>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by bgiffel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Jul 2011 05:01:15 AM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1