buglwIP - A Lightweight TCP/IP stack - Bugs: bug #33871, rejecting TCP_EVENT_RECV() for the...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33871: rejecting TCP_EVENT_RECV() for the last packet including FIN can lose data

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Wed 27 Jul 2011 05:23:34 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: CVS Head

Fri 23 Sep 2011 05:20:43 PM UTC, comment #1:

Fixed (updated summary: it's only a problem if the FIN was amended to the last packet that contained data).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 27 Jul 2011 05:23:34 PM UTC, original submission:

If a packet contains both data and the FIN flag, TCP_EVENT_RECV() is called for the data before calling TCP_EVENT_CLOSED() (recv with NULL pointer).

Now when the application rejects the data (by returning != ERR_OK), and the data is stored in pcb->refused_data, TCP_EVENT_CLOSED() is still called and thus data can get lost. tcp_fasttmr() still calls TCP_EVENT_RECV() while the pcb is on the tcp_active_pcbs lists, so the data might arrive or not, but if it arrives, it arrives after the closed-indication.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 23 Sep 2011 05:20:43 PM UTCgoldsimonPlanned Release=>1.4.1
      Summaryrejecting TCP_EVENT_RECV() for the last packet before FIN can lose data=>rejecting TCP_EVENT_RECV() for the last packet including FIN can lose data
    Fri 23 Sep 2011 05:20:42 PM UTCgoldsimonOpen/ClosedOpen=>Closed
    Fri 23 Sep 2011 05:20:41 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon

    Back to the top


    Powered by Savane 3.1-cleanup1