buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34170, Memory leak in sntp_send_request()

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34170: Memory leak in sntp_send_request()

Submitted by:  Gustl <gustl>
Submitted on:  Tue 30 Aug 2011 05:54:28 AM UTC  
 
Category: ContribSeverity: 3 - Normal
Item Group: Crash ErrorStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 1.4.0

Thu 01 Sep 2011 07:12:17 PM UTC, comment #3:

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 30 Aug 2011 07:40:46 AM UTC, comment #2:

I can verify the memory leak. And the patch seem to be correct and working.

Åke Forslund <ake>
Tue 30 Aug 2011 05:56:36 AM UTC, comment #1:

Forgot to mention the file: sntp.c

Gustl <gustl>
Tue 30 Aug 2011 05:54:28 AM UTC, original submission:

This allocation is never freed:
p = pbuf_alloc(PBUF_TRANSPORT, SNTP_MSG_LEN, PBUF_RAM);

I suggest to add a
pbuf_free(p);
right after this line:
udp_sendto(sntp_pcb, p, server_addr, SNTP_PORT);

Gustl <gustl>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by ake (Posted a comment)
  • -unavailable- added by gustl (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 01 Sep 2011 07:12:17 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1