bugSimulavr: an AVR simulator - Bugs: bug #34287, commit...

 
 

bug #34287: commit f658676ad64c4e10f9dff8da808869ee26b0a2e3 breaks python simulation

Submitted by:  Marek Pietrzak <mpie>
Submitted on:  Tue 13 Sep 2011 07:19:05 PM UTC  
 
Category: SimulationSeverity: 3 - Normal
Item Group: NoneStatus: Ready For Test
Privacy: PublicAssigned to: Petr Hluzin <petrh>
Open/Closed: ClosedComponent Version: simulavrxx

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 14 Sep 2011 07:05:36 PM UTC, comment #1:

The patch in question: http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=f658676ad64c4e10f9dff8da808869ee26b0a2e3

You are right. The commit changed behavior when cpuCycles > 0, the old code relied on `int bpFlag = 0;'. Therefore SystemClock::RunTimeRange() incorrectly returned after executing a single instruction.

Fixed in http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=a46be63133461aef9258e928dcc6db469b16be93

Petr Hluzin <petrh>
Project MemberIn charge of this item.
Tue 13 Sep 2011 07:19:05 PM UTC, original submission:

Commit submitted on Thu Aug 11 21:55:24 2011 +0200 results in SystemClock::Step() returning non-zero in a normal situation (without breakpoint). It breaks python simulation examples. Also calling SystemClock::RunTimeRange() will return immediately without running the expected time range.

Marek Pietrzak <mpie>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by petrh (Posted a comment)
  • -unavailable- added by mpie (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 14 Sep 2011 07:05:36 PM UTCpetrhStatusNone=>Ready For Test
      Assigned toNone=>petrh
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1