bugranger - Bugs: bug #34307, Error on canceling non-existent...

 
 

bug #34307: Error on canceling non-existent command: ranger 1.4.3

Submitted by:  Joshua <veedrac>
Submitted on:  Fri 16 Sep 2011 07:28:18 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Sep 2011 01:25:18 AM UTC, comment #1:

Thank you, I wonder why I didn't notice this!

Roman Z. <hut>
Project Administrator
Fri 16 Sep 2011 07:28:18 PM UTC, original submission:

The cancel methods of commands are there to remove side effects. They are not purposely used as functions, but to cancel them. It thus follows that there is no need to show an error if a non-existent command is canceled. This diff for gui/widgets/console.py which makes the canceling call _get_cmd with a quiet flag which hides errors.

128c128
< cmd = self._get_cmd()
---

> cmd = self._get_cmd(quiet=True)

327c327
< def _get_cmd(self):
---

> def _get_cmd(self, quiet=False):

331c331
< self.fm.notify("Invalid command! Press ? for help.", bad=True)
---

> if not quiet: self.fm.notify("Invalid command! Press ? for help.", bad=True)

Joshua <veedrac>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hut (Posted a comment)
  • -unavailable- added by veedrac (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 17 Sep 2011 01:25:18 AM UTChutStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1